Skip to content

Fix torn reads in value node caches - #10540

Merged
tobias-tengler merged 1 commit into
mainfrom
tte/fix-value-node-cache-publication
Oct 13, 2026
Merged

tobias-tengler merged 1 commit into
mainfrom
tte/fix-value-node-cache-publication

Conversation

@tobias-tengler

@tobias-tengler tobias-tengler commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Fix #10506

@tobias-tengler
tobias-tengler force-pushed the tte/fix-value-node-cache-publication branch from 493a61b to c09fb19 Compare October 13, 2026 15:30
@github-actions

Copy link
Copy Markdown
Contributor

Patch coverage

67.9% of changed lines covered (91/134)

File Covered Changed Patch %
…/Language/src/Language.SyntaxTree/IntValueNode.cs 48 88 54.5% 🔴
…/Language/src/Language.SyntaxTree/FloatValueNode.cs 15 18 83.3% 🟡
…/Utilities/src/Utilities.Buffers/ReadOnlyMemorySegment.cs 28 28 100.0% 🟢
Uncovered changed lines (JSON)
{
  "sha": "38bb06e1ccd7c175b04b52967b2122f57b879530",
  "files": [
    { "path": "src/HotChocolate/Language/src/Language.SyntaxTree/IntValueNode.cs", "ranges": [[425, 427], [429, 429], [431, 431], [479, 480], [482, 482], [484, 484], [486, 486], [534, 534], [541, 541], [589, 594], [596, 596], [644, 644], [646, 647], [649, 649], [651, 651], [699, 701], [704, 704], [706, 706], [754, 757], [761, 761], [809, 814]] },
    { "path": "src/HotChocolate/Language/src/Language.SyntaxTree/FloatValueNode.cs", "ranges": [[250, 250], [288, 288], [328, 328]] }
  ]
}

Project coverage: 58.7% (315851/538324 lines)

@tobias-tengler
tobias-tengler marked this pull request as ready for review October 13, 2026 16:40
Copilot AI balanced review requested due to automatic review settings October 13, 2026 16:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@tobias-tengler
tobias-tengler merged commit ec3667a into main Oct 13, 2026
158 checks passed
@tobias-tengler
tobias-tengler deleted the tte/fix-value-node-cache-publication branch October 13, 2026 16:41
glen-84 pushed a commit that referenced this pull request Oct 19, 2026
This was referenced Oct 20, 2026
This was referenced Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IntValueNode.Value is not thread-safe on first read, producing empty literals and invalid SDL

2 participants