Repository navigation
[Fusion] Fold leaf Apollo lookups into a deeper identical lookup - #10628
Merged
Merged
Conversation
Contributor
Patch coverage95.2% of changed lines covered (100/105)
Uncovered changed lines (JSON){
"sha": "380ff6e7078981a077ce70facbdd5dd0fb425959",
"files": [
{ "path": "src/HotChocolate/Fusion/src/Fusion.Execution/Planning/OperationPlanner.BuildExecutionTree.cs", "ranges": [[1244, 1246], [1283, 1284]] }
]
}Project coverage: 59.1% (313252/529604 lines) |
tobias-tengler
changed the base branch from
main
to
tte/fusion-merge-apollo-entity-lookups
October 19, 2026 06:44
tobias-tengler
force-pushed
the
tte/fusion-fold-leaf-apollo-lookups
branch
from
October 20, 2026 15:20
44c4182 to
2cfd93f
Compare
tobias-tengler
force-pushed
the
tte/fusion-fold-leaf-apollo-lookups
branch
from
October 20, 2026 15:55
aeabaf6 to
0edb63b
Compare
tobias-tengler
marked this pull request as ready for review
October 20, 2026 16:08
tobias-tengler
force-pushed
the
tte/fusion-fold-leaf-apollo-lookups
branch
from
October 20, 2026 16:30
0edb63b to
075fc9e
Compare
tobias-tengler
force-pushed
the
tte/fusion-fold-leaf-apollo-lookups
branch
3 times, most recently
from
October 20, 2026 16:49
62fff41 to
c777442
Compare
Base automatically changed from
tte/fusion-merge-apollo-entity-lookups
to
main
October 20, 2026 16:58
An Apollo entity lookup that no plan node depends on now joins a structurally identical lookup at a greater dependency depth when that lookup already waits for all of the leaf's dependencies. No selections are added to any lookup and no dependent waits longer; the leaf's representations move into the existing deeper request.
tobias-tengler
force-pushed
the
tte/fusion-fold-leaf-apollo-lookups
branch
from
October 20, 2026 17:00
c777442 to
f9a708d
Compare
This was referenced Oct 25, 2026
This was referenced Oct 26, 2026
This was referenced Nov 2, 2026
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 21 updates
DFE-Digital/SUI_Matcher#424
Open
Bump HotChocolate.AspNetCore.Pipeline and HotChocolate.Fusion.AspNetCore
feddi-dev/feddi-gateway#109
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An Apollo Federation lookup that nothing in the plan depends on is sent as its own
_entitiesrequest, even when a structurally identical lookup for the same entity runs at a greater dependency depth. In the apollo-federation benchmark query the inventory lookup fortopProductsruns alone in the second wave, while the same inventory lookup for three nested product paths runs in the fourth wave.This PR moves such a leaf lookup into the deeper identical lookup when that lookup already waits for all of the leaf's dependencies, so its representations are sent with the existing deeper request. A shallower lookup that other nodes depend on stays separate.
OperationPlanner.Versiongoes to 2.4.0.