Repository navigation
Fix flags enum input rejecting an object with every flag false - #10709
Merged
Merged
Conversation
Contributor
Patch coverage100.0% of changed lines covered (4/4)
Project coverage: 59.5% (317675/534260 lines) |
This was referenced Oct 28, 2026
Open
Merged
This was referenced Nov 3, 2026
Bump HotChocolate.AspNetCore.Pipeline and HotChocolate.Fusion.AspNetCore
feddi-dev/feddi-gateway#109
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
EnableFlagEnumsturned on, a flags enum input where every flag isfalsefails with "Flags need to have at least one selection". This means a client cannot set a flags value to zero. It also means a zero value the API returns cannot be sent back, because the output shows zero as an object with every flagfalse.The input now treats an explicit
falseas a selection, so an object with no flag set totrueand at least one flag set tofalsebecomes0. An empty object{}and an object where every field isnullstill fail with the same error as before.