Repository navigation
Fix UseConnection ignoring global paging options in cost analysis - #9975
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a cost analysis discrepancy where connection fields configured via [UseConnection] could ignore globally configured paging options (notably MaxPageSize) during schema-cost metadata generation, leading to skewed @listSize(assumedSize: ...) values.
Changes:
- Update
[UseConnection]attribute configuration to set merged paging options (including global defaults) onto field features during type creation. - Add regression tests validating that
@listSize.assumedSizehonors globalMaxPageSizefor[UseConnection]when no per-field override is provided. - Add coverage for explicit per-field overrides via
[UseConnection(MaxPageSize = ...)].
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/HotChocolate/CostAnalysis/test/CostAnalysis.Tests/ConnectionOverridePagingCostTests.cs | Adds regression tests ensuring @listSize.assumedSize reflects global and per-field paging options for [UseConnection]. |
| src/HotChocolate/Core/src/Types.CursorPagination/Extensions/UseConnectionAttribute.cs | Ensures paging options stored on field features are merged with global paging options early enough for cost analysis defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+35
to
+53
| // [UsePaging] and [UseConnection] are two ways to declare the same connection field, so they | ||
| // must derive the same @listSize.assumedSize from the global MaxPageSize when no per-field | ||
| // override is set. The source-gen connection shape (connection flag + [UseConnection]) must | ||
| // match too. | ||
| [Fact] | ||
| public async Task ListSize_AssumedSize_Should_Be_Equal_For_UsePaging_And_UseConnection_Without_Override() | ||
| { | ||
| // arrange & act | ||
| var usePaging = await GetBooksAssumedSizeAsync(b => b.AddQueryType<UsePagingQuery>()); | ||
| var useConnection = await GetBooksAssumedSizeAsync(b => b.AddQueryType<NoOverrideQueryType>()); | ||
| var sourceGenConnection = await GetBooksAssumedSizeAsync(b => b.AddQueryType<NoOverrideQueryType>()); | ||
|
|
||
| // assert | ||
| Assert.Equal(100, usePaging); | ||
| Assert.Equal(100, useConnection); | ||
| Assert.Equal(100, sourceGenConnection); | ||
| Assert.Equal(usePaging, useConnection); | ||
| Assert.Equal(usePaging, sourceGenConnection); | ||
| } |
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall coverage in the Show a code coverage summary of the most impacted files.
Code Coverage is in Public Preview. Learn more and provide us with your feedback. |
Contributor
Patch coverage100.0% of changed lines covered (1/1)
Project coverage: 52.4% (215284/411029 lines) |
This was referenced Jul 7, 2026
This was referenced Jul 14, 2026
This was referenced Sep 7, 2026
Closed
This was referenced Sep 15, 2026
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#405
Closed
This was referenced Sep 22, 2026
Closed
Closed
[nuget][SUI_Matcher]- Bump the sui-package-updates group with 20 updates
DFE-Digital/SUI_Matcher#410
Merged
This was referenced Oct 5, 2026
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.