Skip to content

Linear: parse_message for ordinary comments returns empty thread id and unknown author (upstream parity) #285

Description

@patrick-chinchill

Follow-up from #280 / #232 review (pre-existing gap, not a regression).

For ordinary comments (kind: "comment"), Python LinearAdapter.parse_message returns thread_id="" and a hardcoded "unknown" author (user_name/full_name), reading comment.userId.

Upstream parseMessage (chat@4.41.1 packages/adapter-linear/src/index.ts:2385-2427) encodes linear:{issueId}:c:{comment.id} and reads the structured comment.user (id, displayName, fullName, type === "bot").

Core does not call parse_message (the comment webhook builds messages in _build_message, comment fetch in _comment_node_to_message), so routing is unaffected; this only matters to consumers calling adapter.parse_message(raw) directly.

Suggested fix: encode the thread id from comment.issueId/comment.id, and read comment.user when present (falling back to userId for the flat webhook shape). Port upstream's ordinary-comment parseMessage test assertions on threadId/author.

Tracked as a known-divergence row in docs/UPSTREAM_SYNC.md ("Linear parse_message for ordinary comments").

Part of #184

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions