test(teams): make the skip-auth fixture survive the SDK's flag rename - #180
Merged
Merged
Conversation
microsoft-teams-apps 2.0.14+ renamed HttpServer.initialize's skip_auth keyword to dangerously_allow_unauthenticated_requests. The four test-side monkeypatches re-declared the old signature, so every Teams webhook test failed with 'unexpected keyword argument' as soon as CI resolved 2.0.16 (uv.lock is not tracked, so CI installs the latest matching 2.0.x). The fixtures now force whichever flag the installed SDK has and forward the rest untouched. Full suite green on both 2.0.13.4 and 2.0.16 (5147 passed). Claude-Session: https://claude.ai/code/session_01AxCf56kzyzW2AhTDoSc3wa
patrick-chinchill
added a commit
that referenced
this pull request
Sep 2, 2026
…NOTICE (#181) Python-only fixes on top of 4.31.0 (UPSTREAM_PARITY unchanged): the #178 security fix, the #180 test-fixture fix and the #179 NOTICE. Mirrors the 0.4.31.1 release-commit shape (pyproject, README status line, CLAUDE.md version list, CHANGELOG). Claude-Session: https://claude.ai/code/session_01AxCf56kzyzW2AhTDoSc3wa
This was referenced Sep 30, 2026
[4.41/T3] Teams inbound: author email hydration, protected inline attachments, secure downloads
#218
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
microsoft-teams-apps2.0.14+ renamedHttpServer.initialize'sskip_authkeyword todangerously_allow_unauthenticated_requests. The four test-side monkeypatches (_skip_teams_jwtintest_teams_coverage.py,test_teams_extended.py,test_teams_adapter.py,test_fixture_replay.py) re-declared the old signature, so every Teams webhook test fails withTypeError: unexpected keyword argument 'dangerously_allow_unauthenticated_requests'once CI resolves 2.0.16 — which it does on every run, becauseuv.lockisn't tracked and theteamsextra only says>=2.0.13.main's last green run predates the 2.0.14 release; this is why #179 (docs-only) is red.What
The fixtures now force whichever flag the installed SDK has (
inspect.signature) and forward all other arguments untouched (the SDK callsinitializewith keywords only). No source changes.Verification
Full suite locally: 5147 passed on
microsoft-teams-apps2.0.13.4 (locked) and again on 2.0.16 (what CI installs).https://claude.ai/code/session_01AxCf56kzyzW2AhTDoSc3wa