Repository navigation
fix(teams): cap microsoft-teams SDK below 2.1 - #251
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Teams SDK dependency bounds now exclude versions 2.1 and later in the Teams extra, the ChangesTeams SDK version cap
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The cap is applied consistently, and the inspected SDK releases retain the adapter APIs. No actionable merge-blocking issue is established. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the version line, Comment |
|
Merge gate: CI green (test 3.12/3.13, Lint & Type Check, CodeQL); CodeRabbit approved; local Codex review ( |
Why
Every open 4.41-wave PR (#242–#249) has red CI on the same 3 Teams tests, and so does a fresh CI run on
main.uv.lockis gitignored and the Teams SDK extras were unbounded (>=2.0.13), so installs now resolvemicrosoft-teams-apps2.1.0 (2026-09-16), which:App.activity_sender, used by native DM streaming atteams/adapter.py:943; andupdatesignature used byedit_messageservice-URL retargeting.This is a runtime break for fresh installs, not only a test failure.
Change
Caps
microsoft-teams-{apps,api,cards}at>=2.0.13,<2.1in all three dependency lists (the teams extra, the all extra and the dev group), which resolves to 2.0.16. Adds a CHANGELOG entry.Validation
Fresh
uv sync --group dev --all-extras→ teams-apps/api/cards 2.0.16 (the transitive teams-common 2.1.0 works with it). Full pytest: 5147 passed, 13 skipped. Ruff is clean.Real 2.1 support is tracked in #250. Merge this first, then the wave PRs rebase onto a green
main.Part of #184
Summary by CodeRabbit