Repository navigation
fix(mobile): keep PR activity in place during pull-to-refresh - #3
Closed
Claudesaul wants to merge 1 commit into
Closed
Claudesaul wants to merge 1 commit into
Claudesaul wants to merge 1 commit into
Conversation
Owner
Author
|
Opened upstream as pingdotgg#20196. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On mobile, pulling to refresh on a PR's Activity tab shows a second spinner above the activity rows. It pushes the rows down about 100 pt, then they snap back when the fetch finishes.
Change
The activity's
pendingcame fromresult.isPending, which is also true while refetching with data already on screen. It's nowresult.isPending && !result.data, so the spinner only shows on first load, like the PR header and diff already do.Scope and approval
Small fix for an obvious bug: a refresh shouldn't hide loaded activity behind a duplicate spinner. No other change to the Activity tab.
Verification
On the iOS 27 simulator, I pulled to refresh on the Activity tab of the same public PR. Before the fix, a second spinner appears under "All activity" and the rows jump. With the fix, only the pull-to-refresh spinner shows and the rows stay put.