Skip to content

Fix deltaLakeAzure url encoded path - #103525

Merged
alexey-milovidov merged 1 commit into
masterfrom
deltaLakeAzure_blob_error
Apr 26, 2026
Merged

Fix deltaLakeAzure url encoded path#103525
alexey-milovidov merged 1 commit into
masterfrom
deltaLakeAzure_blob_error

Conversation

@SmitaRKulkarni

@SmitaRKulkarni SmitaRKulkarni commented Apr 24, 2026

Copy link
Copy Markdown
Member

Closes: #103509

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix processing of url encoded path in deltaLakeAzure resolves

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Version info

  • Backported to: 26.4.4.27

@clickhouse-gh

clickhouse-gh Bot commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Workflow [PR], commit [c167a15]

Summary:


AI Review

Summary

This PR decodes URI-encoded Delta log file paths before resolving data file locations, fixing DeltaLakeAzure reads for partition directories that contain encoded characters (for example %40). The change is small, focused, and covered by a dedicated integration test that reproduces the encoded-path scenario.

ClickHouse Rules
Item Status Notes
Deletion logging
Serialization versioning
Core-area scrutiny
No test removal
Experimental gate
No magic constants
Backward compatibility
SettingsChangesHistory.cpp
PR metadata quality
Safe rollout
Compilation time
No large/binary files
Final Verdict
  • Status: ✅ Approve

@clickhouse-gh clickhouse-gh Bot added the pr-bugfix Pull request with bugfix, not backported by default label Apr 24, 2026
@clickhouse-gh

clickhouse-gh Bot commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

LLVM Coverage Report

Metric Baseline Current Δ
Lines 83.80% 83.80% +0.00%
Functions 91.10% 91.10% +0.00%
Branches 76.20% 76.20% +0.00%

Changed lines: 100.00% (14/14) · Uncovered code

Full report · Diff report

@alexey-milovidov alexey-milovidov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not look wrong for me, thank you!

@alexey-milovidov
alexey-milovidov added this pull request to the merge queue Apr 26, 2026
@alexey-milovidov alexey-milovidov self-assigned this Apr 26, 2026
Merged via the queue into master with commit 77d8190 Apr 26, 2026
325 of 326 checks passed
@alexey-milovidov
alexey-milovidov deleted the deltaLakeAzure_blob_error branch April 26, 2026 11:41
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Apr 26, 2026
@clickgapai

Copy link
Copy Markdown
Contributor

Hi — this PR may need backporting to 26.3 (LTS), 26.2, 26.1, 25.8 (LTS), but no backport label was found.

Affected code: DeltaLakeMetadataImpl::processMetadataFile and DeltaLakeMetadataImpl::getCheckpointIfExists in DeltaLakeMetadata.cpp — core code present in all supported branches.

Why: User-visible bug fix in DeltaLakeMetadataImpl::processMetadataFile and DeltaLakeMetadataImpl::getCheckpointIfExists. Git log shows DeltaLakeMetadata.cpp predates all supported branches (file existed long before 25.8 release date 2025-08-29). Affected code path is the legacy non-kernel reader, present in every supported branch.

If this should be backported, consider adding pr-must-backport or a version-specific label (e.g. v26.3-must-backport). Ignore this if backporting is not applicable.

@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jun 2, 2026
robot-ch-test-poll4 added a commit that referenced this pull request Jun 2, 2026
Cherry pick #103525 to 26.4: Fix deltaLakeAzure url encoded path
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jun 2, 2026
alexey-milovidov added a commit that referenced this pull request Jun 3, 2026
Backport #103525 to 26.4: Fix deltaLakeAzure url encoded path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo v26.4-must-backport

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DeltaLakeAzure does not percent-decode add.path from the Delta log → 404 for any partition value containing URL-encoded characters

6 participants