Repository navigation
Conversation
earwin
force-pushed
the
fix-column-values-retain
branch
from
September 18, 2026 16:08
3ec4859 to
c4b2c54
Compare
…set() Reset() of ColEnum, ColLowCardinality, ColRawOf truncates value buffers without clearing them, retaining references to potentially large blocks of text. This adds a clear() before truncate.
earwin
force-pushed
the
fix-column-values-retain
branch
from
September 18, 2026 16:10
c4b2c54 to
3e1bbea
Compare
Author
|
Sorry for bumping this, @kavirajk @chersner your thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reset() of ColEnum, ColLowCardinality, ColRawOf truncates value buffers without clearing them. This retains references to value strings, which can in turn retain references to larger buffers these strings were cut out from.
I'm now running a clear() on buffers that zeroes out the references, before truncating them.
Saves me a few hundred MBs of RAM in some ingestor runs.