Repository navigation
fix: close client after query transport errors - #1203
Open
OrangeFlag wants to merge 1 commit into
Open
OrangeFlag wants to merge 1 commit into
OrangeFlag wants to merge 1 commit into
Conversation
Contributor
Author
|
@kavirajk please take a look when you have time |
Contributor
Author
|
@chernser, maybe you could take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes query cleanup after transport-level failures.
Client.Donow closes the client after unsuccessful non-server-error queries, so a broken connection is not returned tochpool. Server-side ClickHouse exceptions still leave the connection reusable.Added a regression test for a read-side transport failure.
Checklist