Add GitHub Actions CI: macOS, iOS, Linux, Windows, Android - #3
Merged
Conversation
Five-platform matrix mirroring the SwiftBash workflow: full build + test on macOS / Linux / Windows / Android, and a compile-only check on iOS (covers the `#if canImport(Subprocess)` gating that keeps the module building when swift-subprocess is platform-excluded). Simpler than SwiftBash's setup because ShellKit has no C-library deps — swift-argument-parser and swift-subprocess are pure Swift, so the Linux job needs no `apt-get install` and the Windows job needs no vcpkg provisioning. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The auto-generated SPM scheme is `ShellKit`, not `ShellKit-Package`. The latter is the convention some Xcode versions / SPM generators use, but for this package xcodebuild lists the scheme as plain `ShellKit`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8546909238
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
odrobnik
added a commit
that referenced
this pull request
Jun 5, 2026
`setup-xcode` only switches among Xcodes already installed on the chosen image, but the macOS/iOS jobs requested xcode-version 26.0 on `macos-latest`, which is not guaranteed to point at an image carrying Xcode 26 — when the `-latest` alias rotates to an older image both jobs fail before build/test. Pin to `macos-26`, the native Xcode 26 image (ships Xcode 26.0.1), so the toolchain selection is deterministic. Resolves the unresolved Codex P1 on #3. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
odrobnik
added a commit
that referenced
this pull request
Jun 5, 2026
`setup-xcode` only selects among Xcodes already installed on the image, but the macOS/iOS jobs requested xcode-version 26.0 on `macos-latest`, which isn't guaranteed to carry Xcode 26 — when the `-latest` alias rotates to an older image both jobs fail before build/test. Pin to `macos-15`, which ships Xcode 26.0.1 AND pre-installs the iOS platform build-ios needs. (`macos-26` carries Xcode 26 but not the iOS SDK, so it would need a per-run `xcodebuild -downloadPlatform iOS`.) Resolves the unresolved Codex P1 on #3. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
odrobnik
added a commit
that referenced
this pull request
Jun 5, 2026
`setup-xcode` only selects among Xcodes already installed on the image, but the macOS/iOS jobs requested xcode-version 26.0 on `macos-latest`, which isn't guaranteed to carry Xcode 26 — when the `-latest` alias rotates to an older image both jobs fail before build/test. Pin to `macos-15`, which ships Xcode 26.0.1 AND pre-installs the iOS platform build-ios needs. (`macos-26` carries Xcode 26 but not the iOS SDK, so it would need a per-run `xcodebuild -downloadPlatform iOS`.) Resolves the unresolved Codex P1 on #3. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code