feat: rename instrumentation to simulation#150
Merged
GuillaumeLagrange merged 2 commits intoNov 17, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #150 will degrade performances by 29.96%Comparing Summary
Benchmarks breakdown
|
`instrumentation` is still accepted as an input, but it maps to simulation internally, as we plan to phase it out.
GuillaumeLagrange
force-pushed
the
cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now
branch
from
November 17, 2025 13:27
98bb927 to
8e5ffb4
Compare
GuillaumeLagrange
force-pushed
the
cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now
branch
2 times, most recently
from
November 17, 2025 13:39
cca86af to
d0c2838
Compare
GuillaumeLagrange
marked this pull request as ready for review
November 17, 2025 13:46
not-matthias
approved these changes
Nov 17, 2025
adriencaccia
approved these changes
Nov 17, 2025
GuillaumeLagrange
force-pushed
the
cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now
branch
2 times, most recently
from
November 17, 2025 14:27
bec3fc5 to
a49996f
Compare
GuillaumeLagrange
force-pushed
the
cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now
branch
from
November 17, 2025 14:28
a49996f to
9181bce
Compare
GuillaumeLagrange
deleted the
cod-1441-accept-simulation-as-a-value-instrumentation-which-is-now
branch
November 17, 2025 15:13
|
Note that this was a breaking change because it changes the location of the benchmark binary (it's now stored under |
Contributor
Author
|
@MichaReiser Indeed, although we do consider this implementation details, as we recommend caching Thanks for pointing this out and sorry for the frustration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instrumentationis still accepted as an input, but it maps to simulation internally, as we plan to phase it out.