Skip to content

feat(inputs): add labels and example placeholders to every input field - #143

Merged
DeepDiver1975 merged 1 commit into
mainfrom
feat/labeled-input-placeholders
Aug 27, 2026
Merged

feat(inputs): add labels and example placeholders to every input field#143
DeepDiver1975 merged 1 commit into
mainfrom
feat/labeled-input-placeholders

Conversation

@DeepDiver1975

Copy link
Copy Markdown
Collaborator

Summary

  • Every input field across the app now has a visible label and an anonymized-example placeholder (z. B. ...) instead of one that restates the label or gives an instruction, per ui concept: always labels next to input fiels - placeholders show examples #137.
  • Added AnonymizedExampleData as the single source of example data (replacing duplicated test fixtures) and a HeaderedContentControl.field style so a field can't be added without a label.
  • Fixed several UI inconsistencies surfaced while reviewing: Kräfte's STATUS combo was shorter than its neighbors, tab titles landed at different vertical positions depending on sibling content, CO-Messung was missing a title, and its "Wohnung bearbeiten" editor had a spinner on a no-min/max field, a redundant close button, and a misaligned checkbox.
  • Added render-test coverage for Funktionen, ETB, and the Task dialog (previously untested).

Test plan

  • dotnet test tests/LageBuch.AppLogic.Tests — 285 passed
  • Acceptance test suite (xunit v3 in-process runner) — 89 passed, 1 pre-existing skip
  • Verified full solution builds clean except the pre-existing, unrelated Android-SDK-not-installed error in this environment
  • Screenshots reviewed manually for every touched view

Closes #137

🤖 Generated with Claude Code

https://claude.ai/code/session_01EgFDVXVsJVKJAw1fxBETFR

Issue #137 asks that every input field always show a visible label and
that placeholders show anonymized example data instead of restating
the label or giving an instruction. The Kraefte tab was the closest
existing model, but only one field in the whole app actually followed
the pattern; ~9 other views had the same gap in one direction or the
other (missing labels, or placeholders that just repeat the label).

- Add AnonymizedExampleData (Persistence/MasterData) as the single
  source of anonymized example values and "z. B. ..." placeholders,
  replacing three duplicated test fixtures.
- Add a HeaderedContentControl.field style so a field structurally
  cannot be added without a visible label.
- Apply labels + example placeholders across every view with input
  fields: Kraefte, Funktionen, ETB, Atemschutz, Aufgaben, CO-Messung,
  Dateien, the Stammdaten editor, and the operator join dialog.
  Free-text fields (Bemerkung, Eintrag, Aufgabe) intentionally get no
  placeholder.
- Unify TasksView/TaskDialogView's separate "cellLabel" style into the
  same tracked-out label style used everywhere else.
- Fix a stale KRAEFTE tab index in ForcesTabRenderTests (left over from
  when the AUFGABEN tab was inserted) so its screenshots show what
  they claim to.
- Fix incidental UI bugs surfaced while reviewing screenshots: a
  hardcoded MinHeight on the Kraefte STATUS combo that made it shorter
  than every other input; inconsistent title-row vertical alignment
  across tabs; a missing CO-MESSPROTOKOLL title; CO-Messung's editor
  sidebar (spinner buttons on a field with no real min/max, a
  redundant close button next to an existing Abbrechen button,
  checkbox/label misalignment).
- Add render-test coverage for Funktionen, ETB, and the Task dialog,
  which previously had none.

Closes #137

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EgFDVXVsJVKJAw1fxBETFR
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
@DeepDiver1975
DeepDiver1975 force-pushed the feat/labeled-input-placeholders branch from fedd800 to 362d1cf Compare August 27, 2026 11:01
@DeepDiver1975
DeepDiver1975 merged commit 430f073 into main Aug 27, 2026
3 checks passed
@DeepDiver1975
DeepDiver1975 deleted the feat/labeled-input-placeholders branch August 27, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ui concept: always labels next to input fiels - placeholders show examples

1 participant