London | 26-ITP-May | Martin Mwaka | Sprint 1 | Form Controls#1369
Open
Temceo wants to merge 9 commits into
Open
London | 26-ITP-May | Martin Mwaka | Sprint 1 | Form Controls#1369Temceo wants to merge 9 commits into
Temceo wants to merge 9 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
Temceo
added
🏕 Priority Mandatory
cjyuan
reviewed
May 30, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code is error free and well formatted. Form is well structured. Well done.
Comment on lines
+62
to
+68
| </body> | ||
| </html> | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Can you look up why keeping trailing empty lines (blank lines at the end of a files) is generally considered poor practice in repositories?
Formatting tool such as prettier can often help us get rid of them automatically.
As a best practice, consider following this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command to ensure your code is always consistently formatted.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I have forked the original form controls and made updates on a branch (sprint1_control_forms).
I have add a new form using semantic html with labels and controls for entry of name, email, colour and sizes