London | May - 26 | Liridona Shehu | Sprint 2 | Wireframe#1371
Open
shehu-dona wants to merge 3 commits into
Open
London | May - 26 | Liridona Shehu | Sprint 2 | Wireframe#1371shehu-dona wants to merge 3 commits into
shehu-dona wants to merge 3 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
8 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjyuan
reviewed
May 30, 2026
Comment on lines
11
to
14
| <h1>Wireframe</h1> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| </p> |
Contributor
There was a problem hiding this comment.
Can you also replace these placeholder text?
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <img src="https://docs.github.com/assets/cb-69181/images/help/repository/headings-toc.png" alt="read.md img"/> |
Contributor
There was a problem hiding this comment.
Providing meaningful alt text is important because it ensures images are accessible to people using screen readers and also helps when images
fail to load, giving users essential context about the content or function of the image.
Can you think of a more descriptive alt value to every image?
Comment on lines
+41
to
+47
| Think of it like creating a copy of your project where you can safely:<br> | ||
|
|
||
| Add new features<br> | ||
| Fix bugs<br> | ||
| Test ideas<br> | ||
|
|
||
| while the original code remains unchanged. |
Contributor
There was a problem hiding this comment.
Using <br> to force line break is a poor practice.
Can you find a more suitable HTML elements, with or without using CSS, to list the three phrases on line 43-45?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Learners, PR Template
Self checklist
Changelist
Wireframe project completed. It has 2 articles with 3 different images and links.