Make compatible dotfiles directory creation for all platforms#4
Merged
Conversation
Contributor
|
Hello @devngl, @JavierCane and @rgomezcasas I came here to fork the project and work on this error but I see that you had already a solution I modify the sed to :
I don't know what solution it's better |
Member
|
@josecarlosduran I prefer with You can create a PR with that change :), but for now I'm merging this! Thanks to both!! |
jsuero286
pushed a commit
to jsuero286/dotly
that referenced
this pull request
Aug 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently
sedcommand has different implementations depending on the platform, after a few tests in both Mac and GNU the only way I found to make it work is to actually replace said command.More information can be found at:
https://stackoverflow.com/questions/4247068/sed-command-with-i-option-failing-on-mac-but-works-on-linux
On the other hand the
cp -rcommand wasn't working for me either, looks like the trailing slash is needed (but I don't understand exactly why as it seems Ok without it).