Skip to content

Source generators should check for cancellation more often #703

Closed

Description

@Sergio0694

Overview

Currently, the MVVM Toolkit source generators are propagating the cancellation token in each callback to all calls that need one, but they're not checking for cancellation themselves that much. This can increase overhead when concurrent invocations are triggered, as previous runs of the generators will take longer before they get to a point where they can detect they've been cancelled. We should update them to add more cancellation checks in places that make sense.

Activity

  1. moved this to 📋 Backlog in 8.2.1on May 16, 2023
  2. changed the title [-]The MVVM Toolkit source generators should check for cancellation more often[/-] [+]Source generators should check for cancellation more often[/+] on May 16, 2023
  3. moved this from 📋 Backlog to 🏗 In progress in 8.2.1on May 16, 2023
  4. moved this from 🏗 In progress to ✅ Done in 8.2.1on Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    analyzer 👓A new analyzer being implemented or updatedmvvm-toolkit 🧰Issues/PRs for the MVVM Toolkitoptimization ☄Performance or memory usage improvements

    Type

    No type

    Projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions