Eliminate this = default shortcut when height * width = 0#1130
Merged
Sergio0694 merged 1 commit intoNov 24, 2025
Conversation
marcin-krystianc
force-pushed
the
dev-20251028-span2d
branch
2 times, most recently
from
October 30, 2025 14:57
054dd66 to
4896877
Compare
marcin-krystianc
force-pushed
the
dev-20251028-span2d
branch
4 times, most recently
from
November 12, 2025 08:12
f11b6d6 to
d22d13b
Compare
marcin-krystianc
marked this pull request as ready for review
November 12, 2025 09:07
Sergio0694
force-pushed
the
dev-20251028-span2d
branch
2 times, most recently
from
November 24, 2025 22:47
c96362e to
668b259
Compare
Sergio0694
force-pushed
the
dev-20251028-span2d
branch
from
November 24, 2025 22:52
668b259 to
8323145
Compare
This was referenced Mar 24, 2026
This was referenced Jul 2, 2026
This was referenced Jul 11, 2026
This was referenced Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1101
Previously, when creating 2D memory structures (
Memory2D<T>,ReadOnlyMemory2D<T>,Span2D<T>,ReadOnlySpan2D<T>) with zero height or width, some constructors would take a shortcut by settingthis = default. This approach had issues because it didn't properly preserve non-zero dimensions (e.g., a 4×0 or 0×7 structure would become 0×0). Additionally, theOverflowHelper.ComputeInt32Areamethod could return non-zero values whenheight=0due to an invalid formula.Solution
Removed the this = default shortcuts from all 2D memory structure constructors
Fixed calculation in
OverflowHelper.ComputeInt32Area:Added comprehensive tests to verify empty structures maintain correct dimensions
PR Checklist
Other information