Add os_disk_caching and data_disk_caching builder operations for VM/VMSS - #1252
Merged
Merged
Conversation
…ta_disk_caching builder operations Agent-Logs-Url: https://github.com/CompositionalIT/farmer/sessions/d172f1d8-a5d0-42ed-94fa-643e1afebd05 Co-authored-by: ninjarobot <1520226+ninjarobot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/CompositionalIT/farmer/sessions/d172f1d8-a5d0-42ed-94fa-643e1afebd05 Co-authored-by: ninjarobot <1520226+ninjarobot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add VM/SS disk cache controls for Data and OS disks
Add os_disk_caching and data_disk_caching builder operations for VM/VMSS
Apr 19, 2026
ninjarobot
marked this pull request as ready for review
September 27, 2026 17:29
ninjarobot
approved these changes
Sep 27, 2026
ninjarobot
left a comment
Collaborator
There was a problem hiding this comment.
New features look right and created the VM and VMSS disks with the correct settings. Regression tested. Approved.
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 27, 2026
…he-controls Add os_disk_caching and data_disk_caching builder operations for VM/VMSS 7b8946b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes the
cachingproperty for OS and data disks on VMs and VM Scale Sets, allowing control over host-level disk caching behavior.The changes in this PR are as follows:
Common.fs: AddedCachingTypeDU (NoCaching→"None",ReadOnly,ReadWrite) andCaching: CachingType optionfield toDiskInfoBuilders.Vm.fs: Addedos_disk_cachinganddata_disk_cachingbuilder operations; caching is applied inRuncomposably alongsidedisk_delete_option; only applies to image-based OS disks and empty data disks (not attached disks)Compute.fs:storageProfilenow emitscachingin ARM output when set; omitted (not null-emitted) when unset, preserving Azure's default behaviourNoCachingARM value, absence when unset, and composition withdisk_delete_optionI have read the contributing guidelines and have completed the following:
If I haven't completed any of the tasks above, I include the reasons why here:
Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure: