Ngmix v2.0#740
Closed
martinkilbinger wants to merge 57 commits into
Closed
Conversation
- bin/ scripts were untracked, causing Docker build to fail - Fix license field to use SPDX string format (MIT) to resolve SetuptoolsDeprecationWarning Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…bugs when exp list is empty
Fix check on zero-valued pixels (most did not pass), now all vignets with at least one != 0 pixel pass.
cailmdaley
added a commit
that referenced
this pull request
Jun 10, 2026
…staged review Autonomous prep for the interactive review. Built the new module against real ngmix 2.4.0 on candide and ran do_ngmix_metacal: shear recovery unbiased (m=+2e-4). Centroid fix harmless but necessity not reproduced. CI never ran (fork PR). Draft GitHub comments + report.html staged for the call. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
cailmdaley
added a commit
that referenced
this pull request
Jun 10, 2026
Re-reviewed against current #741 head: no code changed since the part-2 review, so all 11 findings stand. Martin closed fork PR #740 and consolidated onto #741 (canonical, green, mergeable); engaged only to ack the RNG fix. Triaged 11 findings (5 cut-and-dry / 5 decisions / 1 resume); weight-norm (949) + *_psfo (1045) flagged as the only two merge-gates. report.html rewritten as next-steps triage; summary comment posted to #741 (issuecomment-4626968551); prs-in-flight indexed with #740-closed disposition. Report-only round; fiber closed for Cail's review. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewer Checklist
developbranch