Conversation
Unit Test Report 1 files 1 suites 4m 39s ⏱️ For more details on these failures, see this check. Results for commit 9631290. |
Merged
martinkilbinger
approved these changes
Apr 20, 2022
sfarrens
reviewed
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some improvements on the
jackknife_weighted_average.replace=True(the default value) which will lead to issues because some object will be counted multiple times. This is actually very likely to happen when we compute both the additive bias and the PSF leakage because we don't remove a lot of objects. It is like randomly picking 9 value between [0, 10] you will have repeated numbers. That slowdown the process.