removed PSF leakage#76
Merged
martinkilbinger merged 2 commits intoSep 13, 2023
Merged
Conversation
…_psf_leakage repo
Conflicts: sp_validation/io.py sp_validation/plots.py sp_validation/util.py
Contributor
Author
|
Minor changes, merged without review. |
cailmdaley
added a commit
that referenced
this pull request
Jul 3, 2026
…module Companion to CosmoStat/cs_util#76, which brings sp_validation's cosmology theory-curve machinery into cs_util.cosmo (the single home for the collaboration's cosmology primitives, per a conversation with Martin). Deletes src/sp_validation/cosmology.py and repoints every consumer to cs_util.cosmo: - package: b_modes.py, cosmo_val/core.py, cosmo_val/pseudo_cl.py - scripts: papers/bmodes/scripts/precompute_pure_eb_chunk.py, scratch/guerrini/namaster_utils.py - docs/comments: workflow/common.py, papers/bmodes/config/covariance.md Drops "cosmology" from sp_validation.__all__ and removes the now-duplicated tests/test_cosmology.py (moved to cs_util alongside the code). No call sites change -- the functions are byte-identical, only their home moved. Temporarily sources cs_util from #76's branch so this PR validates before #76 merges; restore "cs_util>=0.2.2" once #76 merges and 0.2.2 ships to PyPI. Part of CosmoStat/cs_util#75. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013NCc4BHtZ4Lx6n9zuUwEeP
cailmdaley
added a commit
that referenced
this pull request
Jul 3, 2026
cs_util releases are infrequent while the two repos iterate together, so sp_validation tracks cs_util's develop branch directly as a git dependency rather than a version pin. Replaces the temporary pointer at #76's feature branch (which would break when that branch is deleted on merge). This PR's cosmology repoint goes green once CosmoStat/cs_util#76 merges into develop. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013NCc4BHtZ4Lx6n9zuUwEeP
cailmdaley
added a commit
that referenced
this pull request
Jul 6, 2026
…module (#223) * refactor(cosmology): move cosmology into cs_util.cosmo; delete local module Companion to CosmoStat/cs_util#76, which brings sp_validation's cosmology theory-curve machinery into cs_util.cosmo (the single home for the collaboration's cosmology primitives, per a conversation with Martin). Deletes src/sp_validation/cosmology.py and repoints every consumer to cs_util.cosmo: - package: b_modes.py, cosmo_val/core.py, cosmo_val/pseudo_cl.py - scripts: papers/bmodes/scripts/precompute_pure_eb_chunk.py, scratch/guerrini/namaster_utils.py - docs/comments: workflow/common.py, papers/bmodes/config/covariance.md Drops "cosmology" from sp_validation.__all__ and removes the now-duplicated tests/test_cosmology.py (moved to cs_util alongside the code). No call sites change -- the functions are byte-identical, only their home moved. Temporarily sources cs_util from #76's branch so this PR validates before #76 merges; restore "cs_util>=0.2.2" once #76 merges and 0.2.2 ships to PyPI. Part of CosmoStat/cs_util#75. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013NCc4BHtZ4Lx6n9zuUwEeP * build: track cs_util's develop branch (not a PyPI pin) cs_util releases are infrequent while the two repos iterate together, so sp_validation tracks cs_util's develop branch directly as a git dependency rather than a version pin. Replaces the temporary pointer at #76's feature branch (which would break when that branch is deleted on merge). This PR's cosmology repoint goes green once CosmoStat/cs_util#76 merges into develop. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013NCc4BHtZ4Lx6n9zuUwEeP * refactor: repoint remaining PLANCK18 references to cs_util.cosmo workflow/rules/covariance.smk imported sp_validation.cosmology.PLANCK18 inside the cosmology_params rule's embedded python — a runtime break once cosmology.py is deleted. Repoint it and the two comment/docstring references (generate_cosmocov_ini.py, papers/bmodes config) to cs_util.cosmo. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ExsQmDDttuhMxSZ6BWmMr9 --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is now in the shear_psf_leakage repository.
All functions removed from py scripts.
Notebooks yet to be updated.
Deals in parts with #46 .