Fix #4734: Normalize contextPath handling in bitstream download route

[hernanhlagos]

References

• Fixes Bitstream download route fails when DSpace is deployed under a custom context path #4734

Description

This PR fixes the generation of bitstream download URLs when DSpace Angular
is deployed under a custom context path (e.g. /repository).
Previously, the environment.ui.nameSpace was ignored, resulting in broken download links (404 Not Found).

Instructions for Reviewers

List of changes in this PR:

• Normalize environment.ui.nameSpace before building the download route
• Ensure / is omitted but custom paths (e.g. /repository) are correctly prepended
• Prevent generation of double slashes in URLs

How to test

1. Deploy DSpace Angular under a custom context path, e.g. http://localhost:4000/repository.
2. As an administrator, edit an Item and go to the Edit Item screen.
3. Select the Files tab.
4. In the BUNDLE: ORIGINAL, TEXT, THUMBNAIL, LICENSE section, click the download icon in the Actions column.
5. Observe the generated download URL:
   • Expected: http://localhost:4000/repository/bitstreams/<uuid>/download
   • Actual before fix: http://localhost:4000/bitstreams/<uuid>/download → results in 404 Not Found.
6. Verify that download links now work correctly under both root (/) and subpath deployments.

Checklist

• My PR is created against the main branch of code.
• My PR is small in size and focused on a single fix.
• My PR passes ESLint validation using npm run lint.
• My PR doesn't introduce circular dependencies (npm run check-circ-deps).
• My PR includes clear instructions for testing this fix.
• This fix has been verified on DSpace Angular 7.4 and 9.1.

[tdonohue]

@hernanhlagos : Thanks for the PR! Just a note that this seems to be failing a few tests. It may just be that the tests require updates, not exactly sure. But, you should be able to see these failures locally if you run npm test

[github-actions]

Hi @hernanhlagos,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

[hernanhlagos]

After a delay on my side and after reviewing the current state of the branches, I found that this PR is now outdated against main.

When I originally opened it, the target branch was still aligned with the version where I reproduced the issue. Since then, the code has changed significantly in main, and this issue appears to be already resolved in dspace-10_x.

However, I have confirmed that the issue still persists in dspace-9_x. After comparing with dspace-10_x, I found that the correct fix for dspace-9_x is much smaller and should be submitted as a clean bugfix against that branch. In short, the fix is to use [routerLink] instead of [href] for the bitstream download button, so Angular resolves the link using the configured UI namespace / base href.

I'll close this PR and open a new one based directly on the current dspace-9_x branch, with the focused fix.

Thanks for reviewing the PR and sorry for the delay in following up.