Remove testcontainer dependencies for buildId tests#11689
Remove testcontainer dependencies for buildId tests#11689gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
amarziali
added
comp: testing
|
PerfectSlayer
left a comment
PerfectSlayer
left a comment
There was a problem hiding this comment.
👏 praise: Thanks for hardening the tests!
bric3
left a comment
bric3
left a comment
There was a problem hiding this comment.
LGTM, I think ading ad REME in the buildid resource folder might be useful. If we ever need revisiting this.
There was a problem hiding this comment.
suggestion: I'd add a simple/basic README.md in buildid/ folder, to explain what are those files and how to produce them (where they are coming from, etc).
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
gh-worker-dd-mergequeue-cf854d
Bot
merged commit 504877c
into
master
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
andrea.marziali/crastracking-testing
branch
3 participants
What Does This Do
This PR removes the need of having docker containers spun up to test the extraction of ELF and PE files. This resulted to be flaky. Instead, it uses deterministic fixtures to ensure that the parsing is working well.
The fixtures are part of the original files only keeping the preamble that's needed to parse the information. The other conten t is dropped (i.e. for PE DLL we drop code and import sections).
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]