Support Maven smoke test apps by bric3 · Pull Request #11695 · DataDog/dd-trace-java

bric3 · 2026-06-22T16:56:32Z

What Does This Do

Adds Maven support to the smoke-test-app plugin and migrates the OpenLiberty smoke test applications to it.

Motivation

Keep nested smoke-test application builds on shared Gradle wiring while preserving the checked-in Maven wrapper for pinned Maven execution.

Additional Notes

GitLab now uses the Maven Wrapper MVNW_REPOURL repository-manager override instead of rewriting maven-wrapper.properties.

The smoke-test-app plugin now has separate Gradle and Maven application entry points. OpenLiberty smoke tests can use the shared nested-build wiring instead of bespoke Exec tasks, while existing Gradle smoke-test apps keep the same task model. Maven apps still launch through the checked-in root mvnw instead of an installed mvn. Keeping mvnw preserves the Maven version pinned by .mvn/wrapper/maven-wrapper.properties and gives CI and local builds the same cross-platform launcher. CI no longer rewrites maven-wrapper.properties to use MASS. Apache Maven Wrapper documents MVNW_REPOURL as the repository-manager override, so GitLab exports it from MAVEN_REPOSITORY_PROXY and trims the trailing slash before mvnw appends the Maven distribution path: https://maven.apache.org/tools/wrapper/#Using_a_Maven_Repository_Manager The Maven path is covered by smoke-test plugin tests. ProjectBuilder verifies mavenApp task wiring, and the TestKit end-to-end test runs a fake mvnw with MAVEN_REPOSITORY_PROXY. It also asserts the nested Maven process receives MVNW_REPOURL.

datadog-datadog-prod-us1-2 · 2026-06-22T16:59:35Z

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

Check pull requests | Check pull requests

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 2a2da2a | Docs | Datadog PR Page | Give us feedback!}

dd-octo-sts · 2026-06-22T17:02:20Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8d8083c592

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-22T17:08:31Z

+  @get:InputFile
+  @get:PathSensitive(PathSensitivity.RELATIVE)
+  abstract val mavenExecutable: RegularFileProperty


Track the Maven wrapper properties as task inputs

Because this cacheable task only declares the wrapper script itself as an input, changes to .mvn/wrapper/maven-wrapper.properties are invisible even though the checked-in mvnw reads that file to choose the Maven distribution. When the pinned Maven version/checksum or wrapper distribution settings change, mvnStage can still be considered up-to-date or restored from cache and keep the artifact built with the previous Maven; please add the wrapper properties file (and any other wrapper files the script reads) as task inputs.

Useful? React with 👍 / 👎.

AlexeyKuznetsov-DD

LGTM, nice improvement.
left several cosmetic comments

dd-octo-sts · 2026-06-22T17:21:10Z

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite	Status
Startup	🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results

Scenario	Candidate	master	Δ (95% CI of mean)
startup:insecure-bank:iast:Agent	13.93 s	13.90 s	[-0.5%; +1.0%] (no difference)
startup:insecure-bank:tracing:Agent	12.94 s	13.02 s	[-1.4%; +0.1%] (no difference)
startup:petclinic:appsec:Agent	16.76 s	16.09 s	[-0.1%; +8.5%] (no difference)
startup:petclinic:iast:Agent	16.91 s	16.87 s	[-0.5%; +1.1%] (no difference)
startup:petclinic:profiling:Agent	16.63 s	16.91 s	[-2.7%; -0.6%] (maybe better)
startup:petclinic:sca:Agent	16.88 s	16.83 s	[-0.6%; +1.2%] (no difference)
startup:petclinic:tracing:Agent	16.01 s	16.01 s	[-1.1%; +1.0%] (no difference)

Commit: 2a2da2a2 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Only wire Gradle stop and Maven build timeouts when the smoke app DSL sets them explicitly. Add Maven cache coverage that deletes the app output directory and verifies the jar is restored from the outer build cache. Mirror the output assertion for the existing Gradle cache test.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a2da2a230

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

bric3 · 2026-06-23T11:05:44Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-06-23T11:05:49Z

View all feedbacks in Devflow UI.

2026-06-23 11:05:49 UTC ℹ️ Start processing command /merge

2026-06-23 11:06:00 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-06-23 11:32:08 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-06-23 12:36:15 UTC ℹ️ MergeQueue: This merge request was merged

bric3 marked this pull request as ready for review June 22, 2026 17:02

bric3 requested review from a team as code owners June 22, 2026 17:02

bric3 requested review from AlexeyKuznetsov-DD, claponcet, greghuels, leoromanovsky, manuel-alvarez-alvarez, randomanderson and ygree and removed request for a team June 22, 2026 17:02

greghuels removed their request for review June 22, 2026 17:02

chatgpt-codex-connector Bot reviewed Jun 22, 2026

View reviewed changes

AlexeyKuznetsov-DD approved these changes Jun 22, 2026

View reviewed changes

bric3 force-pushed the bdu/smoke-test-maven-app branch 2 times, most recently from 5d07637 to a417f04 Compare June 23, 2026 10:10

bric3 added 2 commits June 23, 2026 12:22

fix(smoke): address Maven app review feedback

0d9029b

bric3 force-pushed the bdu/smoke-test-maven-app branch from a417f04 to 2a2da2a Compare June 23, 2026 10:38

bric3 marked this pull request as draft June 23, 2026 10:38

bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling type: feature Enhancements and improvements labels Jun 23, 2026

bric3 marked this pull request as ready for review June 23, 2026 10:41

chatgpt-codex-connector Bot reviewed Jun 23, 2026

View reviewed changes

Comment thread build-logic/smoke-test/src/main/kotlin/datadog/buildlogic/smoketest/NestedMavenBuild.kt

gh-worker-dd-mergequeue-cf854d Bot merged commit 635c6b8 into master Jun 23, 2026
587 of 594 checks passed

gh-worker-dd-mergequeue-cf854d Bot deleted the bdu/smoke-test-maven-app branch June 23, 2026 12:36

github-actions Bot added this to the 1.64.0 milestone Jun 23, 2026

Uh oh!

Conversation

bric3 commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Uh oh!

datadog-datadog-prod-us1-2 Bot commented Jun 22, 2026 • edited by datadog-official Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

Uh oh!

dd-octo-sts Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 22, 2026

Choose a reason for hiding this comment

Uh oh!

AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dd-octo-sts Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 Java Benchmark SLOs — All performance SLOs passed

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

bric3 commented Jun 23, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bric3 commented Jun 22, 2026 •

edited

Loading

datadog-datadog-prod-us1-2 Bot commented Jun 22, 2026 •

edited by datadog-official Bot

Loading

dd-octo-sts Bot commented Jun 22, 2026 •

edited

Loading

dd-octo-sts Bot commented Jun 22, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jun 23, 2026 •

edited

Loading