Skip to content

Add SCA benchmark gitlab config#11697

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
sarahchen6/fix-sca-benchmark-ordering
Jun 22, 2026
Merged

Add SCA benchmark gitlab config#11697
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
sarahchen6/fix-sca-benchmark-ordering

Conversation

@sarahchen6

@sarahchen6 sarahchen6 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Add the same benchmark configurations to SCA benchmarks as we have for the other load benchmarks

Motivation

SCA benchmarks would fail occasionally if run before the publish-artifacts-to-s3 job completed. The load benchmark Gitlab configuration ensures that these benchmarks run after the publish-artifacts-to-s3 job completed.

Additional Notes

We can see that the Gitlab job dependencies are configured correctly now in the pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/pipelines/120292368 (click "Show dependencies" to see the job dependency graph).

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@sarahchen6 sarahchen6 added type: bug fix Bug fix tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jun 22, 2026
@sarahchen6 sarahchen6 marked this pull request as ready for review June 22, 2026 17:52
@sarahchen6 sarahchen6 requested review from a team as code owners June 22, 2026 17:52
@sarahchen6 sarahchen6 requested review from AlexeyKuznetsov-DD, amarziali and erikayasuda and removed request for a team June 22, 2026 17:52
@datadog-prod-us1-5

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.90 s 13.93 s [-0.9%; +0.5%] (no difference)
startup:insecure-bank:tracing:Agent 12.87 s 13.03 s [-1.9%; -0.7%] (maybe better)
startup:petclinic:appsec:Agent 16.68 s 16.69 s [-0.9%; +0.8%] (no difference)
startup:petclinic:iast:Agent 16.91 s 16.80 s [-0.3%; +1.6%] (no difference)
startup:petclinic:profiling:Agent 16.77 s 16.92 s [-1.9%; +0.2%] (no difference)
startup:petclinic:sca:Agent 16.94 s 16.72 s [+0.4%; +2.2%] (maybe worse)
startup:petclinic:tracing:Agent 16.03 s 15.59 s [-1.6%; +7.2%] (no difference)

Commit: 3e625007 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@sarahchen6

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jun 22, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-22 18:53:37 UTC ℹ️ Start processing command /merge


2026-06-22 18:53:42 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-06-22 19:54:46 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit ea827ba into master Jun 22, 2026
794 of 802 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the sarahchen6/fix-sca-benchmark-ordering branch June 22, 2026 19:54
@github-actions github-actions Bot added this to the 1.64.0 milestone Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants