[WEB-9185] Clamp integration tile descriptions with ellipsis overflow#37412
Open
Jackie-Robson wants to merge 1 commit into
Open
[WEB-9185] Clamp integration tile descriptions with ellipsis overflow#37412Jackie-Robson wants to merge 1 commit into
Jackie-Robson wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
Long descriptions on the /integrations/ page were silently overflowing the tile bounds with no visual indicator. Clamps the hover .blurb to 3 lines with a trailing ellipsis using -webkit-line-clamp and max-height. Resolves WEB-9185
3c16854 to
5d10925
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Fixes WEB-9185
Integration tiles on the /integrations/ page have a fixed height of 164px. On hover, tiles flip to show the description but long descriptions were silently overflowing the tile bounds with no visual indicator, unlike the Datadog app which shows a trailing ellipsis.
Change: Added -webkit-line-clamp: 4 to .integration.hover .blurb in _integrations.scss. This clamps the description to 4 lines and shows a trailing ellipsis when text overflows, matching the expected behaviour.
Merge instructions
Merge readiness:
Additional notes
-webkit-line-clamp has full cross-browser support (Chrome, Firefox, Safari, Edge).