Skip to content

Improve detecting subclass of Thread #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhengyu123 merged 4 commits into from
Aug 18, 2026
Merged

Improve detecting subclass of Thread #741

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cde867c
Improve detecting subclass of Thread
zhengyu123 Aug 18, 2026
e51ceef
Potential fix for pull request finding
zhengyu123 Aug 18, 2026
69ce94b
Fix
zhengyu123 Aug 18, 2026
b3732ff
Merge branch 'main' into zgu/thread_subclass
zhengyu123 Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions ddprof-lib/src/main/cpp/flightRecorder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,20 +254,13 @@ void Lookup::fillJavaMethodInfo(MethodInfo *mi, jmethodID method,
jclass Thread_class = jni->FindClass("java/lang/Thread");
jclass Class_class = jni->FindClass("java/lang/Class");
if (Thread_class != nullptr && Class_class != nullptr) {
jmethodID equals = jni->GetMethodID(Class_class,
"equals", "(Ljava/lang/Object;)Z");
if (equals != nullptr) {
jclass klass = method_class;
do {
entry = jni->CallBooleanMethod(Thread_class, equals, klass);
if (jniExceptionCheck(jni)) {
entry = false;
break;
}
if (entry) {
break;
}
} while ((klass = jni->GetSuperclass(klass)) != NULL);
jmethodID isAssignableFrom =
jni->GetMethodID(Class_class, "isAssignableFrom", "(Ljava/lang/Class;)Z");
if (isAssignableFrom != nullptr) {
entry = jni->CallBooleanMethod(Thread_class, isAssignableFrom, method_class);
if (jniExceptionCheck(jni)) {
entry = false;
}
}
}
// Clear any exceptions from the reflection calls above
Expand Down
Loading