Variable substitution tokens incompatible with PostgreSQL #1

Activity

1. AdrianJSClark commented on Aug 1, 2017

   

   AdrianJSClark

   on Aug 1, 2017

   Member

   More actions

   There isn't a straightforward seam around the variable substitution code to make that change. However, I've got two ways forward that will work within the current framework. One is a work-around and one is a quick summary of what the fix would be.

   Unfortunately I'm a bit time-poor at the moment, and am not particularly familiar with PostgreSQL, so can't implement either in full myself.

   The Work Around

   1. Create a PostgreSQL-specific variable preprocessor by inheriting from VariableSubstitutionSqlParser and specifying your own delimiter characters.
   2. Create your own implementation of IScriptPreprocessor based on the existing VariableSubstitutionPreprocessor code with the important change of using your custom subclass of VariableSubstitutionSqlParser from the first step.
   3. Disable the built-in variable substitution pre-processor by calling .WithVariablesDisabled() at configuration time.
   4. Add your custom script preprocessor to your database upgrader using the .WithPreprocessor(...) extension method during configuration.

   The Proper Fix

   1. Create a PostgreSQL-specific variable preprocessor by inheriting from VariableSubstitutionSqlParser and specifying appropriate delimiter characters.
   2. Create a PostgreSQL implementation of IScriptPreprocessor based on the existing VariableSubstitutionPreprocessor code with the important change of using the custom subclass of VariableSubstitutionSqlParser from the first step.
   3. Copy and modify SqlScriptExecutor so that it creates the customised PostgreSQL variable substitution preprocessor at the appropriate time.
   4. Update all configuration extension methods for PostgreSQL to wire-in the replacement, specialised SqlScriptExecutor.

   👍React with 👍1Reacted by Alexandre Nourissier
2. sungam3r

   added

   bugSomething isn't workingSomething isn't working

   and removed

   bugSomething isn't workingSomething isn't working

   on Aug 21, 2023
3. droyad

   transferred this issue fromDbUp/DbUpon Jan 30, 2024
4. droyad commented on Dec 10, 2024

   

   droyad

   on Dec 10, 2024

   Member

   More actions

   Also see linked issues for more use cases