Repository navigation
fix: correct the Homebrew version claim in the footer and update hint - #375
Conversation
#370 corrected the README: tap trust has been required since Homebrew 6.0.0, not 7.0, and `brew trust` exists on 6.x rather than being absent there. The same wrong claim was still in the GoReleaser footer, which generates it into every release, and in the `unic update` hint. Per docs.brew.sh/Tap-Trust, non-official taps require explicit trust since 6.0.0, and whole-tap trust covers "every current and future formula, cask and external command from that tap" — so the hint now uses the same formula-scoped command the README settled on. Also restores the literal error string to the README. Anyone who has already hit this searches the message rather than reading the install section top-down, and #370 dropped it. Closes #374
|
Warning Review limit reachedNext included review available in 21 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: DevopsArtFactory/unic/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR successfully corrects the Homebrew version requirement from 7.0 to 6.0.0 across all relevant files and updates the trust command to use formula-scoped trust instead of tap-scoped trust. The changes are factually accurate according to Homebrew's documentation and improve security by recommending the more restrictive formula-scoped trust command.
All three files (.goreleaser.yaml, README.md, internal/cli/update.go) are now consistent with each other. The PR includes proper verification against official Homebrew documentation and maintains consistency throughout the codebase.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
1 participant
Summary
#370 fixed the README; this carries the same correction to the two places that still had my original wrong claim.
I verified the facts against Homebrew's documentation rather than either PR's wording:
Tap trust shipped in Homebrew 6.0.0 on 2026-06-11. #369 reported the failure on 7.0.7 and I generalised from that one data point without checking when the requirement actually landed.
Changes
.goreleaser.yamlfooter — said "Homebrew 7.0 refuses ..." and "The subcommand does not exist before 7.0 — skip it there." The second sentence told Homebrew 6.x users to skip a step they need. Now states 6.0.0 and uses the formula-scoped command.unic updatehint — same version comment, and it still suggested tap-scopedbrew trust DevopsArtFactory/unicwhile the README had moved to formula scope. Now consistent.README — restores the literal
Refusing to load formula ... from untrusted tapstring that #370 dropped, and names what the tap-scoped alternative grants, since the docs are explicit that it covers "every current and future formula, cask and external command from that tap". That is the reason to prefer formula scope, so it is worth one clause rather than left implicit.Validation
.goreleaser.yamlwith the repo's owngopkg.in/yaml.v3and printed the unmarshalled footer — parses, renders as intended,changelog.filters.excludeunchangedgo build ./...,go vet ./...,go test ./...passgrepacross*.md,*.go,*.yamlforHomebrew 7,7.0+ only,before 7.0— no remaining hitsNot covered here
The published v0.3.3 and v0.3.4 release notes still carry the wrong claim. Those are edited through the API, not this branch; doing that separately.
Closes #374