Skip to content

Drop Python 2 support and compatibility code#237

Merged
jelmer merged 2 commits into
DiffSK:5.0.xfrom
jelmer:drop-python2
Sep 17, 2024
Merged

Drop Python 2 support and compatibility code#237
jelmer merged 2 commits into
DiffSK:5.0.xfrom
jelmer:drop-python2

Conversation

@jelmer

@jelmer jelmer commented Jun 11, 2023

Copy link
Copy Markdown
Collaborator

This drops support for Python 2, and removes associated compatibility code.

I did this work for a private project (to get rid of the six dependency), but
figured it might be useful upstream as well (since Python 2 is EOL).

@jelmer jelmer changed the title This drops support for Python 2, and removes associated compatibility code Drop Python 2 support and compatibility code Sep 25, 2023
@jelmer

jelmer commented Nov 28, 2023

Copy link
Copy Markdown
Collaborator Author

ping @robdennis

alternatively, anything I can do to help with maintenance?

@a-detiste

Copy link
Copy Markdown

@jelmer

Should we consider using your patch for the Debian package ?

@jelmer

jelmer commented Jan 2, 2024

Copy link
Copy Markdown
Collaborator Author

@a-detiste yeah, that makes sense

It would still be great to merge this upstream too though

@a-detiste

Copy link
Copy Markdown

mock should be removed too

.github/workflows/python-test.yml

-pip install pytest coverage pytest-cov mock
+pip install pytest coverage pytest-cov

@jelmer

jelmer commented Jan 29, 2024

Copy link
Copy Markdown
Collaborator Author

Hey @EliAndrewC , @robdennis , anything we can do to help with the maintenance for the project / help get outstanding PRs / issues resolved?

@EliAndrewC

Copy link
Copy Markdown
Member

I apologize for the delayed response.

Both @robdennis and I are the current maintainers, but we've found we lack the time to review and publish new versions of configobj. In the spirit of good stewardship, we'd be happy to hand over maintainer status to people who are interested in making these kinds of changes, especially people like @jelmer who have already put in the effort to make PRs.

@jelmer , is taking over as maintainer of the project something that you feel you have the bandwidth for? Either solo, or alongside others such as @yegorich who have also filed PRs and inquired about the status of the project? (The last person we tried to hand the project off to had their own life issues arise and were not able to end up taking over, so we'd feel a little better granting this access to multiple people, but the most important thing is to unblock all of these PRs by giving someone the access needed to review and accept them.)

@jelmer

jelmer commented Jan 30, 2024

Copy link
Copy Markdown
Collaborator Author

I apologize for the delayed response.

Both @robdennis and I are the current maintainers, but we've found we lack the time to review and publish new versions of configobj. In the spirit of good stewardship, we'd be happy to hand over maintainer status to people who are interested in making these kinds of changes, especially people like @jelmer who have already put in the effort to make PRs.

@jelmer , is taking over as maintainer of the project something that you feel you have the bandwidth for? Either solo, or alongside others such as @yegorich who have also filed PRs and inquired about the status of the project? (The last person we tried to hand the project off to had their own life issues arise and were not able to end up taking over, so we'd feel a little better granting this access to multiple people, but the most important thing is to unblock all of these PRs by giving someone the access needed to review and accept them.)

Thanks for the reply, @EliAndrewC - yeah, I would be interested in that. I do have bandwidth but I agree having multiple maintainers would be a good idea either way.

@yegorich

Copy link
Copy Markdown
Collaborator

I am also interested in helping to maintain this project. Though, I don't have that much bandwidth.

@jelmer jelmer changed the base branch from release to master January 31, 2024 20:00
@jelmer jelmer changed the base branch from master to release January 31, 2024 20:00
@jelmer

jelmer commented Feb 3, 2024

Copy link
Copy Markdown
Collaborator Author

@EliAndrewC / @robdennis thanks for adding me to the project; what's the current philosophy around the master vs release branches? They appear to have diverged, and afaict I can't merge anything into release.

@jelmer jelmer changed the base branch from release to master February 3, 2024 12:58
@jelmer jelmer changed the base branch from master to release February 3, 2024 12:58
@robdennis

Copy link
Copy Markdown
Member

@EliAndrewC / @robdennis thanks for adding me to the project; what's the current philosophy around the master vs release branches? They appear to have diverged, and afaict I can't merge anything into release.

How I found the project when I last had the cycles to look at it: #213

At the bottom of this thread, I update how I found the state of the two different branches, specifically, the tooling changes introduced (but not AFAICT, fully landed) did not leave me in a place where I felt like I could execute on getting a release out. One of my last comments notes what I though I could do, which was do something targeted off of the last branch I could understand.

This issue describes the last thing I did: #223

my overall philosophy for the project is that there are so many legacy consumers that it’s difficult to imagine anything transformative being done, but also me and Eli are too old to keep up with what idiomatic open source is these days so we’re hoping someone else will.

can you let me know your PYPI username and I can give you credits over there?

@jelmer

jelmer commented Feb 4, 2024

Copy link
Copy Markdown
Collaborator Author

Thanks for the pointers, much appreciated.

can you let me know your PYPI username and I can give you credits over there?

I'm "jelmer" on pypi.

@robdennis

robdennis commented Feb 4, 2024 via email

Copy link
Copy Markdown
Member

ad662

This comment was marked as abuse.

@jelmer jelmer changed the base branch from release to 5.0.x September 17, 2024 10:58
@jelmer jelmer merged commit 3480a6e into DiffSK:5.0.x Sep 17, 2024
@jelmer jelmer mentioned this pull request Sep 17, 2024
@jelmer

jelmer commented Sep 17, 2024

Copy link
Copy Markdown
Collaborator Author

Hi @robdennis ,

I've merged this branch and the DoS PR into 5.0.x, and merged the recent 5.0.x changes into master as well - it'd be good to do another release. Is there any chance you could either give me access to the release branch or release a 5.0.9?

It would also be great if (now that there are github actions) we could require CI to pass for any merges.

@robdennis

Copy link
Copy Markdown
Member

Hi @jelmer,

I had down that you had enough permissions to manage whatever you need to here and on pypi. I just bumped you up to admin level from maintain and hopefully that will give you whatever you need.

My ideal end state is that I'm not in the critical path for anything, since I'm unlikely to see any github emails or other notifications.

@jelmer

jelmer commented Sep 21, 2024

Copy link
Copy Markdown
Collaborator Author

Thanks, @robdennis ! I've just pushed out 5.0.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants