fix: attach dokploy-network at Traefik creation in install.sh - #174
Open
Siumauricio wants to merge 1 commit into
Open
fix: attach dokploy-network at Traefik creation in install.sh#174Siumauricio wants to merge 1 commit into
Siumauricio wants to merge 1 commit into
Conversation
Siumauricio
force-pushed
the
fix/install-traefik-network-at-create
branch
from
August 9, 2026 07:02
3b98105 to
cca80e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh installs created
dokploy-traefikwithout--networkand attacheddokploy-networkafterwards withdocker network connect. Dynamic attachments like that are not restored after an ungraceful reboot (VM resize, power loss) — the container fails withfailed to set up container networkingand--restart alwaysdoes not retry, which is the root cause behind Dokploy/dokploy#4057 (reproduced on Docker 28.x and 29.x; details in Dokploy/dokploy#4057 (comment)).Networks defined in the container's create config survive the same crash reliably (verified repeatedly, including a full VM reboot), so the script now passes
--network dokploy-networktodocker runand drops the separatedocker network connect. Safe at install time: the network is already materialized on the node because the postgres and dokploy services are attached to it before Traefik is created.History note: this reverts f94ed01 (May 2025), which introduced the two-step connect for Dokploy/dokploy#1802 / Dokploy/dokploy#1809. Those reports were a different symptom — Traefik running but not routing after reboot (stale ARP/VIP state, upstream moby/moby#52661) — and the two-step didn't fix reboot recovery: Dokploy/dokploy#3236 and Dokploy/dokploy#4057 (Traefik fully dead after reboot) both happened after that change, caused by the dynamic attachment it introduced.