Repository navigation
Install the kit into .mskit/ and move .toolkit/ installs - #21
Merged
Merged
Conversation
tests/update-dir.test.sh: a fresh install writes .mskit/, --kit-dir picks another folder and kit.json remembers it, an older .toolkit/ install moves (tracked or not) with its references, both folders present is refused, --dry-run changes nothing, and 0.2.1 reaches .mskit/ in two runs with the real v0.2.1 updater.
update.sh: --kit-dir NAME picks the kit folder, recorded as kitDir in kit.json so later runs find it; the default is .mskit. A .toolkit/ install without kitDir moves to the kit folder (git mv when tracked) and .toolkit is rewritten in Directory.Build.*, .gitignore and dependabot.yml; both folders present stops the run; --dry-run reports the move and changes nothing.
-KitDir, kitDir in kit.json, discovery, the move from .toolkit/ with its rewrites, the both-folders refusal and the dry-run report.
MSKit_KitDirName is the kit folder's name; the MSKITROSLYN001..003
errors use it, and their catalog descriptors take it as {2}.
The sample starts as a v0.2.1 install in .toolkit/ that the new update.sh moves, so the self-test builds, tests and packs a migrated tree; TfmConstants keeps .toolkit/ through --kit-dir. tests/run.sh runs tests/update-dir.test.sh; codes, nuget-isolation and docs-check know both folder names.
Every page names .mskit/ as the consumer folder; install-and-update gains --kit-dir, kitDir and a section on the move, including the two-run upgrade from 0.2.1. CHANGELOG lists it as a breaking change.
Windows refuses to move a folder that holds an open file, so moving .toolkit/ failed while sh ran .toolkit/update.sh. update.sh re-runs itself from a temporary copy in that case. update.ps1: the kit build variable no longer shadows -KitDir (PowerShell names are not case sensitive).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installs the kit into
.mskit/instead of.toolkit/, and moves existing installs.update.sh/update.ps1: default kit folder.mskit/;--kit-dir NAME/-KitDirpicks another, recorded askitDirinkit.jsonso later runs find it..toolkit/install (nokitDir) moves to the kit folder (git mvwhen tracked) and.toolkitis rewritten inDirectory.Build.props/.targets,.gitignoreand.github/dependabot.yml. Both folders present: refused.--dry-runreports the move and changes nothing..toolkit/update.sh, the script re-runs from a temp copy, since Windows refuses to move a folder holding an open file.MSKit_KitDirName..mskit/(the sample starts as a v0.2.1 install the new script moves;TfmConstantsstays on--kit-dir .toolkit); docs, CHANGELOG.tests/update-dir.test.sh, run bytests/run.sh.Breaking changes
.mskit/. From 0.2.1 the upgrade takes two runs: 0.2.1's script installs into.toolkit/and copies the new script, which moves the folder on the next run. The release zip keeps its.toolkit/layout for that reason.Follow-ups: the repository's own
kit/.toolkit/source tree andmanager/.toolkit/stay as they are; the manager'skit.jsonschema-1 reader must acceptkitDir.