Repository navigation
Conversation
This was referenced Sep 24, 2026
…p one regression test
Collaborator
Author
|
Superseded by 8a71300 on next, which parses sha256sum.txt with one strict grammar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sha256sum_entry_hashtook the filename as the second whitespace token and dropped the rest of the line. For<h1> measurement.tdx.cbor <h2> measurement.tdx.cborit returnedh1, whilesha256sum -c(filename runs to end of line) matches neither entry, and the hidden second entry escaped the duplicate check.sha256sum.txtis whatos_image_hashcommits to, so this parser andsha256sum -c/ a human reviewer should agree on what it says. Found by property tests (#1249).Fix
Split on the first whitespace run and take the rest of the line as the filename. Well-formed
<hash> <name>manifests parse identically.Verification
Regression test added;
cargo test -p dstack-typespasses; fmt and clippy clean.