Skip to content

fix: say when a probe failed instead of folding it into a default - #1373

Merged
kvinwang merged 2 commits into
nextfrom
fix/warn-on-failed-probes
Sep 24, 2026
Merged

kvinwang merged 2 commits into
nextfrom
fix/warn-on-failed-probes

Conversation

@kvinwang

@kvinwang kvinwang commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Four places swallowed a failure into a default without a trace (#541: silent skips hide corruption). Behaviour is unchanged; each now logs a warning:

  • dstack-volume: modprobe dm-verity and udevadm settle results were discarded with let _.
  • dstack-volume: a failed blkid fs-type probe became "", which silently drops ro,noload for ext4 volumes.
  • dstack-util: an unreadable or malformed gateway cache read the same as a missing one.
  • app-compose.sh: jq ... || echo "" made a malformed .sys-config.json look like "no PCCS configured":
$ printf '%s' '{"pccs_url": "https://pccs.example/' > sc.json
$ CFG=$([ -f sc.json ] && jq -r '.pccs_url//""' sc.json || echo ""); echo "exit=$? [$CFG]"
exit=0 []

Verification: cargo test -p dstack-util -p dstack-volume, clippy and fmt clean; bash -n app-compose.sh; ran the new app-compose.sh snippet against a truncated sys-config (warns, continues with empty PCCS_URL).

@kvinwang
kvinwang merged commit fe7202a into next Sep 24, 2026
15 checks passed
@kvinwang
kvinwang deleted the fix/warn-on-failed-probes branch September 24, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant