Repository navigation
Change GLC_NCPL to 4 for DAE test to pass - #4220
Conversation
|
@billsacks another short review for an issue that you opened. I have not yet tested and, therefore do not yet feel entirely confident about changing GLC_NCPL in the pauseResume testmods directory. I will see how the corresponding test behaves. LMK if you have feedback about that or anything else. Thanks, Bill.
|
billsacks
left a comment
There was a problem hiding this comment.
This seems good. Thanks for taking it on @slevis-lmwg ! I haven't thought through whether this more frequent coupling of DGLC might cause issues scientifically, but in terms of just getting the software tests to pass it feels very reasonable.
I noticed, though, that there is a diff between the current b4b-dev branch and master in this setting of GLC_NCPL: I ran into this problem in my testing on master, where this was set to 2. But I see that the current value is 24 on b4b-dev. I actually suspect that the current setting on b4b-dev is fine. Either way should work, so your call about whether to keep it at the new value of 4 or just go back to 24.
Sorry about apparently opening an issue that was already fixed on b4b-dev.
FYI @ekluzek .
|
I might as well still switch to 4
|
…E_test slevis resolved conflicts: cime_config/testdefs/ExpectedTestFails.xml cime_config/testdefs/testmods_dirs/clm/DA_multidrv/shell_commands cime_config/testdefs/testmods_dirs/clm/pauseResume/shell_commands
|
Merging the latest b4b-dev and resolving the conflicts, I decided to go with the fixes that Erik brought in with b4b-dev, which minimize this PR's diffs. Erik changed the flag to 2 and 4 in the two affected tests, and he updated the comments. All I need to do now is remove the DAE test from the ExpectedFails.
|
|
Ok, so Erik's latest update to the DAE test didn't work, and I still needed to change GLC_NCPL from 2 to 4 as Bill expected.
|
Description of changes
See title, plus remove DAE test from the expected fails.
Specific notes
Contributors other than yourself, if any:
CTSM issues resolved or otherwise addressed, if any:
Resolves #4202
Testing planned or performed, if any:
Requirements before merge: