Skip to content

Change GLC_NCPL to 4 for DAE test to pass - #4220

Merged
slevis-lmwg merged 6 commits into
ESCOMP:b4b-devfrom
slevis-lmwg:chg_GLC_NCPL_in_DAE_test
Sep 21, 2026
Merged

slevis-lmwg merged 6 commits into
ESCOMP:b4b-devfrom
slevis-lmwg:chg_GLC_NCPL_in_DAE_test

Conversation

@slevis-lmwg

@slevis-lmwg slevis-lmwg commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Description of changes

See title, plus remove DAE test from the expected fails.

Specific notes

Contributors other than yourself, if any:

CTSM issues resolved or otherwise addressed, if any:
Resolves #4202

Testing planned or performed, if any:

  • So far I have confirmed that the DAE test works with this PR's first commit
  • Other testing posted in subsequent posts

Requirements before merge:

  • The code in this PR branch builds with no errors.
  • The code in this PR branch runs with no errors. Briefly describe tested configuration(s): DAE test with this PR's first commit.
  • This PR does not change answers.
  • This PR does not create a need to update the documentation.

@slevis-lmwg

slevis-lmwg commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor Author

@billsacks another short review for an issue that you opened.

I have not yet tested and, therefore do not yet feel entirely confident about changing GLC_NCPL in the pauseResume testmods directory. I will see how the corresponding test behaves. LMK if you have feedback about that or anything else. Thanks, Bill.

  • SMS_C2_D_Lh12.f10_f10_mg37.I2000Clm50Sp.derecho_intel.clm-pauseResume submitted
  • Remove this test, too, from the expected fails if it works

@billsacks billsacks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good. Thanks for taking it on @slevis-lmwg ! I haven't thought through whether this more frequent coupling of DGLC might cause issues scientifically, but in terms of just getting the software tests to pass it feels very reasonable.

I noticed, though, that there is a diff between the current b4b-dev branch and master in this setting of GLC_NCPL: I ran into this problem in my testing on master, where this was set to 2. But I see that the current value is 24 on b4b-dev. I actually suspect that the current setting on b4b-dev is fine. Either way should work, so your call about whether to keep it at the new value of 4 or just go back to 24.

Sorry about apparently opening an issue that was already fixed on b4b-dev.

FYI @ekluzek .

@slevis-lmwg
slevis-lmwg marked this pull request as ready for review September 21, 2026 17:17
@slevis-lmwg

Copy link
Copy Markdown
Contributor Author

I might as well still switch to 4

  • to simultaneously correct the accompanying comment. Otherwise I still need to correct the comment to
    #Set DGLC coupling to 24 times per day so 6-hour tests can work
  • to remove the two affected tests from ExpectedFails

…E_test

slevis resolved conflicts:
cime_config/testdefs/ExpectedTestFails.xml
cime_config/testdefs/testmods_dirs/clm/DA_multidrv/shell_commands
cime_config/testdefs/testmods_dirs/clm/pauseResume/shell_commands
@slevis-lmwg

slevis-lmwg commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor Author

Merging the latest b4b-dev and resolving the conflicts, I decided to go with the fixes that Erik brought in with b4b-dev, which minimize this PR's diffs. Erik changed the flag to 2 and 4 in the two affected tests, and he updated the comments. All I need to do now is remove the DAE test from the ExpectedFails.

  • I'm rerunning the two affected tests before considering this done:
./create_test SMS_C2_D_Lh12.f10_f10_mg37.I2000Clm50Sp.derecho_intel.clm-pauseResume -c /glade/campaign/cgd/tss/ctsm_baselines/ctsm5.4.058
./create_test DAE_C2_D_Lh12.f10_f10_mg37.I2000Clm50BgcCrop.derecho_intel.clm-DA_multidrv -c /glade/campaign/cgd/tss/ctsm_baselines/ctsm5.4.058

@slevis-lmwg

slevis-lmwg commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor Author

Ok, so Erik's latest update to the DAE test didn't work, and I still needed to change GLC_NCPL from 2 to 4 as Bill expected.

  • Running the DAE test one last time for sanity

@slevis-lmwg
slevis-lmwg merged commit 4d1c631 into ESCOMP:b4b-dev Sep 21, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in LMWG: Sprint Planning Board Sep 21, 2026
@slevis-lmwg
slevis-lmwg deleted the chg_GLC_NCPL_in_DAE_test branch September 21, 2026 18:58
@slevis-lmwg slevis-lmwg mentioned this pull request Oct 1, 2026
12 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants