Skip to content

ctsm5.4.063: Move CTSM tests from t232 to t233 - #4223

Merged
slevis-lmwg merged 10 commits into
ESCOMP:masterfrom
slevis-lmwg:mv_to_t233
Oct 6, 2026
Merged

slevis-lmwg merged 10 commits into
ESCOMP:masterfrom
slevis-lmwg:mv_to_t233

Conversation

@slevis-lmwg

@slevis-lmwg slevis-lmwg commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor
  • Update branch and then REBASE to master right after the next b4b-dev merge to master

Description of changes

Updating

  • testlist_clm.xml

  • ExpectedTestFails.xml

  • config_compsets.xml

  • .rst and README files that need the update

  • RTM, MOSART, and mizuRoute testlists do not include references to 232

Specific notes

Contributors other than yourself, if any:

CTSM issues resolved or otherwise addressed, if any:
Contributes to #2540
Resolves #4238

Testing planned or performed, if any:

  • ./run_sys_tests -s aux_clm -c ctsm5.4.058 --skip-generate with only ccs_config updated to tag 92 (additional submodules are getting updated on master)
    • derecho tests_0929-181958de
      • LII2FINIDATAREAS_D_P256x2_Ld1.f09_t233.I1850Clm60BgcCrop.derecho_intel.clm-default tests require special handling to pass COMPARE_base_no_interp. Return these to t232 to resolve when we are ready to finalize ICs. Open issue and link to ICs issue.
      • Investigate a few other failures BUT wait to rerun aux_clm after the rebase
    • izumi tests_0929-184523iz, resubmitting one test

Requirements before merge:

  • The code in this PR branch builds with no errors.
  • The code in this PR branch runs with no errors. Briefly describe tested configuration(s):
  • This does not change answers for unchanged tests; tests going from t232 to t233 run on the new grid and have their names updated, so the test-suites will not compare them to the baseline
  • This PR includes required documentation updates
  • Update ChangeLog/Sum

@slevis-lmwg slevis-lmwg self-assigned this Sep 22, 2026
@slevis-lmwg slevis-lmwg added the b4b bit-for-bit label Sep 22, 2026
@slevis-lmwg
slevis-lmwg marked this pull request as ready for review September 22, 2026 21:11
@slevis-lmwg
slevis-lmwg requested a review from ekluzek September 22, 2026 21:11
@slevis-lmwg slevis-lmwg added the blocked: dependency Wait to work on this until dependency is resolved label Sep 22, 2026
@slevis-lmwg

slevis-lmwg commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Blocked by ESMCI/ccs_config_cesm#305 and subsequent CTSM .gitmodules update in ESCOMP master #4232.

@slevis-lmwg

Copy link
Copy Markdown
Contributor Author

@ekluzek only the LII2 tests raise a question in this PR. In particular, these tests require special handling to pass COMPARE_base_no_interp. My preference would be to return these to t232 and resolve later AND/OR move these tests to a grid less likely to change any time soon. What do you think?

@slevis-lmwg slevis-lmwg added testing additions or changes to tests and removed blocked: dependency Wait to work on this until dependency is resolved labels Oct 1, 2026
@slevis-lmwg
slevis-lmwg changed the base branch from b4b-dev to master October 2, 2026 14:45
@slevis-lmwg slevis-lmwg changed the title Move CTSM tests from t232 to t233 ctsm5.4.063: Move CTSM tests from t232 to t233 Oct 5, 2026

@ekluzek ekluzek left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @slevis-lmwg this is great.

I did a "git grep t232" and noticed a few more things to handle...

cime_config/testdefs/ExpectedTestFails.xml:
cime_config/testdefs/testlist_clm.xml:
doc/source/users_guide/setting-up-and-running-a-case/customizing-the-clm-namelist.rst:.. I copied the following file from the baseline for ctsm5.4.047 for the SMS_D_Ld5_PS.f09_f09_mt232.I1850Clm60BgcCrop.derecho_gnu.clm-f09_ObscureStreamOpts test.

On the first two you might as well remove both of those which will complete #4238. The last one might not need anything done with it, but thought it would be good to look at.

@slevis-lmwg

slevis-lmwg commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor Author

./run_sys_tests -s aux_clm -c ctsm5.4.062 -g ctsm5.4.063

  • derecho
  • izumi

@slevis-lmwg
slevis-lmwg merged commit be1aff2 into ESCOMP:master Oct 6, 2026
8 checks passed
@slevis-lmwg
slevis-lmwg deleted the mv_to_t233 branch October 6, 2026 15:45
slevis-lmwg added a commit to slevis-lmwg/ctsm that referenced this pull request Oct 6, 2026
ctsm5.4.063: Move CTSM tests from t232 to t233

Updating testlist_clm.xml, ExpectedTestFails.xml, config_compsets.xml, and documentation that needs updating.

NB: Moving tests from t232 to t233 but postpone the change for LII2 tests (issue ESCOMP#4245).

Changes answers relative to the baseline, only for cases with grids that changed to the t233 grid, and only due to the grid update.

PR ESCOMP#4223
Resolves issue ESCOMP#4238 by removing NorESM test
Contributes to ESCOMP#2540 Move testing from POP to MOM masks

slevis resolved conflicts:
cime_config/testdefs/testlist_clm.xml
slevis-lmwg added a commit to adrifoster/CTSM that referenced this pull request Oct 7, 2026
ctsm5.4.063: Move CTSM tests from t232 to t233

Updating testlist_clm.xml, ExpectedTestFails.xml, config_compsets.xml, and documentation that needs updating.

NB: Moving tests from t232 to t233 but postpone the change for LII2 tests (issue ESCOMP#4245).

Changes answers relative to the baseline, only for cases with grids that changed to the t233 grid, and only due to the grid update.

PR ESCOMP#4223
Resolves issue ESCOMP#4238 by removing NorESM test
Contributes to ESCOMP#2540 Move testing from POP to MOM masks

slevis resolved conflicts:
bld/unit_testers/build-namelist_test.pl
ekluzek added a commit to ekluzek/CTSM that referenced this pull request Oct 14, 2026
ctsm5.4.063: Move CTSM tests from t232 to t233

Updating testlist_clm.xml, ExpectedTestFails.xml, config_compsets.xml, and documentation that needs updating.

NB: Moving tests from t232 to t233 but postpone the change for LII2 tests (issue ESCOMP#4245).

Changes answers relative to the baseline, only for cases with grids that changed to the t233 grid, and only due to the grid update.

PR ESCOMP#4223
Resolves issue ESCOMP#4238 by removing NorESM test
Contributes to ESCOMP#2540 Move testing from POP to MOM masks
samsrabin added a commit that referenced this pull request Oct 16, 2026
ctsm5.4.063: Move CTSM tests from t232 to t233

Updating testlist_clm.xml, ExpectedTestFails.xml, config_compsets.xml, and documentation that needs updating.

NB: Moving tests from t232 to t233 but postpone the change for LII2 tests (issue #4245).

Changes answers relative to the baseline, only for cases with grids that changed to the t233 grid, and only due to the grid update.

PR #4223
Resolves issue #4238 by removing NorESM test
Contributes to #2540 Move testing from POP to MOM masks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit testing additions or changes to tests

Projects

Status: Done (non release/external)
Status: Done

Development

Successfully merging this pull request may close these issues.

New NorESM test fails, needs updates in CMEPS

2 participants