Repository navigation
test(subset_data): make unit test work outside NCAR cluster, like its siblings do - #4231
Merged
Merged
Conversation
… siblings do Have one test case pass 'testing=true' into setup_files(), like its siblings already do, so that it skips checking for a specific /glade file. Assisted-by: gemini-3.8-flash:1.0
This was referenced Sep 27, 2026
ekluzek
approved these changes
Sep 30, 2026
ekluzek
left a comment
Contributor
There was a problem hiding this comment.
This looks good. I checked to make sure instances of setup_files had testing=True, or didn't need it. The instances that don't need it are fail tests with bad input (like a missing directory) is sent in. So they don't need it.
Contributor
|
I'm just going to merge this in, as the testing was done. |
Contributor
Author
|
Thanks @ekluzek ! |
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Have one test case pass 'testing=true' into setup_files(), like its siblings already do, so that it skips checking for a specific /glade file.
Specific notes
Contributors other than yourself, if any:
CTSM issues resolved or otherwise addressed, if any:
Description of generative AI usage:
Google Antigravity was used to write the code and tests, followed by human-guided verification.
Any user interface changes (namelist or namelist defaults changes)?
None
Testing planned or performed, if any:
conda run -n ctsm_pylib ./run_ctsm_py_tests -u(all 602 tests pass cleanly).blackformatting (black --check python/ctsm/test/test_unit_subset_data.py) andpylint(score: 9.97/10).Requirements before merge:
Tested on macOS (Apple Silicon arm64) using the
ctsm_pylibconda environment via./run_ctsm_py_tests -u.(a) does not change answers (test-only change).
(a) does not create a need to update documentation.