Repository navigation
chore(color): replace the bitmaps in the calibration pages with generated UI - #7762
Merged
Merged
Conversation
philmoz
added
color
Member
|
LGTM, especially the better contrasting for the stick position and larger size. Going away from bitmaps to generated controls should also make it possible to make a more appropriate calibration screen for the colour surface radios... 😍 |
55 of 56 tasks
pfeerick
pushed a commit
that referenced
this pull request
Oct 13, 2026
…ated UI (#7762) Co-authored-by: philmoz <philmoz@users.noreply.github.com> (cherry picked from commit e066572) Conflicts resolved by hand for 2.12, which still uses the older bitmap names and layout from before main's #6781 cleanup: - radio_calibration.cpp: 2.12 includes alpha_stick_{pointer,background}.lbm, where main has bmp_radio_stick_*. Removed that include block, as upstream does. - Upstream deletes bitmaps/<res>/bmp_radio_stick_*.png and img-src/bmp_radio_stick_*.svg. On 2.12 the same images are bitmaps/<res>/default_theme/alpha_stick_*.png and img-src/default_theme/alpha_stick_*.svg (picked up by the alpha_*.png glob in the bitmaps CMakeLists), so those are deleted instead. - tools/convert-gfx-list.csv doesn't exist on 2.12 (added by #6781), so upstream's edit to it is dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pfeerick
pushed a commit
that referenced
this pull request
Oct 17, 2026
…ated UI (#7762) Co-authored-by: philmoz <philmoz@users.noreply.github.com> (cherry picked from commit e066572) Conflicts resolved by hand for 2.12, which still uses the older bitmap names and layout from before main's #6781 cleanup: - radio_calibration.cpp: 2.12 includes alpha_stick_{pointer,background}.lbm, where main has bmp_radio_stick_*. Removed that include block, as upstream does. - Upstream deletes bitmaps/<res>/bmp_radio_stick_*.png and img-src/bmp_radio_stick_*.svg. On 2.12 the same images are bitmaps/<res>/default_theme/alpha_stick_*.png and img-src/default_theme/alpha_stick_*.svg (picked up by the alpha_*.png glob in the bitmaps CMakeLists), so those are deleted instead. - tools/convert-gfx-list.csv doesn't exist on 2.12 (added by #6781), so upstream's edit to it is dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Saves ~2.3K on TX16S.
Before:
After:
