warn when n_factors exceeds number of features#149
Open
Qayad-Ali wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FactorAnalyzer.fitcaps the number of factors whenn_factorsis greater than the number of features — it returns a truncated loadings matrix with no indication to the user:In factor analysis the number of factors can't exceed the number of observed variables, so requesting more is mostly always a mistake. This gives a
UserWarningin that case — consistent with the existing warning when the number of factors is constrained by the sample size.Changes
FactorAnalyzer.fit: warn whenn_factors > n_features.tests/test_factor_analyzer.py.No change to results for valid inputs.