Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 0f0eed7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
Merged
arrudaricardo
pushed a commit
to arrudaricardo/effect
that referenced
this pull request
Sep 23, 2026
…Effect-TS#8245) Co-authored-by: Tim Smart <hello@timsmart.co>
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a command scope previously skipped remaining descendants when the leader had already exited successfully or from a signal. Scope release now uses the existing termination routine for referenced POSIX process groups in both cases, applying the configured signal, bounded wait, and escalation policy. It preserves
unref(),detached: false, Windows behavior, and the existing nonzero-exit cleanup.Regression tests release only the leader through a zero exit or external SIGKILL, confirm the descendant remains alive, then verify scope closure waits for descendant termination. Existing lifecycle tests wait for readiness and heartbeat admission before killing. The force-kill test uses a single TERM-ignoring process and checks its signal exit and stopped state.
Validation on Linux: all 77 tests in
NodeChildProcessSpawner.test.ts,pnpm lint-fix, andpnpm checkpassed for the implementation commit. The external-SIGKILL regression failed before the signal-exit fix and now passes.The final comment/changeset cleanup passes lint and formatting. The edited module has no JSDoc diagnostics; the repository-wide
pnpm jsdocs --checkreports two existing description-format errors in unchangedMcpSchema.ts.The module documents the remaining POSIX limitation: if a process-group ID is recycled before cleanup, an unrelated group may be signalled.
Closes EFF-1382