Skip to content

CI Flake test_simple_close_dust_output_omitted #9313

Description

@daywalker90
 def test_simple_close_dust_output_omitted(node_factory, bitcoind):
        """When the closee's output would be below the dust limit it must be
        omitted from the closing tx (closer_output_only TLV variant)."""
        opts = {'experimental-simple-close': None, 'feerates': (3750, 3750, 3750, 3750, 3750)}
        l1, l2 = node_factory.line_graph(2, opts=opts)
        chan = l1.get_channel_scid(l2)
    
        # Give l2 a balance well below the default 546-sat dust limit.
        l1.pay(l2, 400000)   # 400000 msat = 400 sat
        wait_for(lambda: only_one(l2.rpc.listpeerchannels()['channels'])['htlcs'] == [])
    
        l2_bal = only_one(
            l2.rpc.listpeerchannels(l1.info['id'])['channels'])['to_us_msat'] // 1000
        assert l2_bal < 546, f"l2 balance {l2_bal} sat must be below dust limit for this test"
    
        # l1 is the non-lesser side (l1 >> l2), so it sends closer_output_only
        # because the closee (l2) is dust; l2 as closer also has a dust-sized output
        # after subtracting the fee (400 sat balance, fee 3375 sat → capped at 400 sat).
        l1.rpc.close(chan)
        l1.daemon.wait_for_log('Simple close starting')
    
        wait_for(lambda: bitcoind.rpc.getmempoolinfo()['size'] >= 1)
    
        # Every closing tx in the mempool must have exactly 1 output: the dust
        # output is omitted in all variants.  Elements appends an explicit fee
        # output (scriptPubKey type 'fee') which must not be counted here.
        for txid in bitcoind.rpc.getrawmempool():
>           tx = bitcoind.rpc.getrawtransaction(txid, True)

tests/test_closing.py:4234: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
contrib/pyln-testing/pyln/testing/utils.py:468: in f
    res = proxy._call(name, *args)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <bitcoin.rpc.RawProxy object at 0x7fbaf8ec2c50>
service_name = 'getrawtransaction'
args = ('cd7ab089178298c65805a7fbe9392d7af00222a020d2a7c30066e89459d0df9c', True)
postdata = '{"version": "1.1", "method": "getrawtransaction", "params": ["cd7ab089178298c65805a7fbe9392d7af00222a020d2a7c30066e89459d0df9c", true], "id": 1}'
headers = {'Authorization': b'Basic cnBjdXNlcjpycGNwYXNz', 'Content-type': 'application/json', 'Host': 'localhost', 'User-Agent': 'AuthServiceProxy/0.1'}
response = {'error': {'code': -5, 'message': 'No such mempool transaction. Use -txindex or provide a block hash to enable blockchain transaction queries. Use gettransaction for wallet transactions.'}, 'id': 1, 'result': None}
lightningd-2 2026-07-14T01:56:35.324Z DEBUG   038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-channeld-chan#1: peer_out WIRE_SHUTDOWN
lightningd-2 2026-07-14T01:56:35.324Z DEBUG   038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-channeld-chan#1: billboard: Channel ready for use. Shutdown messages exchanged.
lightningd-1 2026-07-14T01:56:35.325Z DEBUG   033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-channeld-chan#1: peer_in WIRE_SHUTDOWN
lightningd-1 2026-07-14T01:56:35.326Z DEBUG   033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-channeld-chan#1: billboard: Channel ready for use. Shutdown messages exchanged.
lightningd-1 2026-07-14T01:56:35.331Z DEBUG   033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-simpleclosed-chan#1: pid 35187, msgfd 91
lightningd-1 2026-07-14T01:56:35.331Z DEBUG   033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-channeld-chan#1: Status closed, but not exited. Killing
lightningd-2 2026-07-14T01:56:35.332Z DEBUG   038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-simpleclosed-chan#1: pid 35188, msgfd 90
lightningd-2 2026-07-14T01:56:35.332Z DEBUG   038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-channeld-chan#1: Status closed, but not exited. Killing
lightningd-1 2026-07-14T01:56:35.335Z INFO    033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-chan#1: State changed from CHANNELD_SHUTTING_DOWN to CLOSINGD_SIGEXCHANGE
lightningd-2 2026-07-14T01:56:35.336Z INFO    038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-chan#1: State changed from CHANNELD_SHUTTING_DOWN to CLOSINGD_SIGEXCHANGE
lightningd-2 2026-07-14T01:56:35.337Z DEBUG   hsmd: new_client: 1
lightningd-1 2026-07-14T01:56:35.339Z DEBUG   hsmd: new_client: 1
lightningd-1 2026-07-14T01:56:35.339Z DEBUG   033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-hsmd: Got WIRE_HSMD_SIGN_MUTUAL_CLOSE_TX
lightningd-1 2026-07-14T01:56:35.339Z DEBUG   hsmd: Client: Received message 21 from client
lightningd-1 2026-07-14T01:56:35.339Z DEBUG   033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-simpleclosed-chan#1: Simple close starting: local=999600sat remote=400sat
lightningd-2 2026-07-14T01:56:35.340Z DEBUG   038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-simpleclosed-chan#1: Simple close starting: local=400sat remote=999600sat
lightningd-2 2026-07-14T01:56:35.340Z DEBUG   038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-hsmd: Got WIRE_HSMD_SIGN_MUTUAL_CLOSE_TX
lightningd-2 2026-07-14T01:56:35.340Z DEBUG   hsmd: Client: Received message 21 from client
lightningd-2 2026-07-14T01:56:35.340Z DEBUG   038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-simpleclosed-chan#1: peer_out WIRE_CLOSING_COMPLETE
lightningd-2 2026-07-14T01:56:35.340Z DEBUG   038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-simpleclosed-chan#1: Sent closing_complete: closer=0sat closee=999600sat fee=400sat
lightningd-1 2026-07-14T01:56:35.342Z DEBUG   033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-simpleclosed-chan#1: peer_out WIRE_CLOSING_COMPLETE
lightningd-1 2026-07-14T01:56:35.342Z DEBUG   033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-simpleclosed-chan#1: Sent closing_complete: closer=996225sat closee=400sat fee=3375sat
lightningd-2 2026-07-14T01:56:35.344Z DEBUG   038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-simpleclosed-chan#1: peer_in WIRE_CLOSING_COMPLETE
lightningd-1 2026-07-14T01:56:35.345Z DEBUG   033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-simpleclosed-chan#1: peer_in WIRE_CLOSING_COMPLETE
lightningd-2 2026-07-14T01:56:35.347Z DEBUG   038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-hsmd: Got WIRE_HSMD_SIGN_MUTUAL_CLOSE_TX
lightningd-2 2026-07-14T01:56:35.347Z DEBUG   hsmd: Client: Received message 21 from client
lightningd-1 2026-07-14T01:56:35.348Z DEBUG   033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-hsmd: Got WIRE_HSMD_SIGN_MUTUAL_CLOSE_TX
lightningd-1 2026-07-14T01:56:35.348Z DEBUG   hsmd: Client: Received message 21 from client
lightningd-1 2026-07-14T01:56:35.349Z DEBUG   033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-simpleclosed-chan#1: Signed closee_output_only: tx=020000000001c6eb43de19b01f5dc1c1f3fb8e0c440131283392fabfa4138db2c0fcc4a130920000000000fdffffff02015ce7b963d37f8f2d51cafbba928aaa9e220b8bbc660571499c03628a3851b8ce0100000000000f40b00016001432c6b8ef183ca258f3080960541e05991d5e2342015ce7b963d37f8f2d51cafbba928aaa9e220b8bbc660571499c03628a3851b8ce010000000000000190000000000000
lightningd-2 2026-07-14T01:56:35.349Z DEBUG   038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-simpleclosed-chan#1: Signed closer_output_only: tx=020000000001c6eb43de19b01f5dc1c1f3fb8e0c440131283392fabfa4138db2c0fcc4a130920000000000fdffffff02015ce7b963d37f8f2d51cafbba928aaa9e220b8bbc660571499c03628a3851b8ce0100000000000f33810016001432c6b8ef183ca258f3080960541e05991d5e2342015ce7b963d37f8f2d51cafbba928aaa9e220b8bbc660571499c03628a3851b8ce010000000000000ebf000000000000
lightningd-1 2026-07-14T01:56:35.349Z DEBUG   033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-simpleclosed-chan#1: peer_out WIRE_CLOSING_SIG
lightningd-1 2026-07-14T01:56:35.349Z DEBUG   033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-simpleclosed-chan#1: Sent closing_sig (as closee), notifying master
lightningd-2 2026-07-14T01:56:35.349Z DEBUG   038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-simpleclosed-chan#1: peer_out WIRE_CLOSING_SIG
lightningd-2 2026-07-14T01:56:35.349Z DEBUG   038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-simpleclosed-chan#1: Sent closing_sig (as closee), notifying master
lightningd-1 2026-07-14T01:56:35.351Z INFO    033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-chan#1: Simple close: stored closee tx cd7ab089178298c65805a7fbe9392d7af00222a020d2a7c30066e89459d0df9c
lightningd-2 2026-07-14T01:56:35.351Z INFO    038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-chan#1: Simple close: stored closee tx e3a50c499caaf8438abae6da9a2c0eb91c8284df99b7de99e14659d5d6b2c5b1
lightningd-1 2026-07-14T01:56:35.351Z DEBUG   033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-simpleclosed-chan#1: peer_in WIRE_CLOSING_SIG
lightningd-2 2026-07-14T01:56:35.351Z DEBUG   038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-simpleclosed-chan#1: peer_in WIRE_CLOSING_SIG
lightningd-1 2026-07-14T01:56:35.351Z DEBUG   033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-simpleclosed-chan#1: closing_sig verified OK, sending to master
lightningd-2 2026-07-14T01:56:35.351Z DEBUG   038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-simpleclosed-chan#1: closing_sig verified OK, sending to master
lightningd-2 2026-07-14T01:56:35.355Z INFO    038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-chan#1: Simple close: stored closer tx cd7ab089178298c65805a7fbe9392d7af00222a020d2a7c30066e89459d0df9c
lightningd-1 2026-07-14T01:56:35.356Z INFO    033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-chan#1: Simple close: stored closer tx e3a50c499caaf8438abae6da9a2c0eb91c8284df99b7de99e14659d5d6b2c5b1
lightningd-2 2026-07-14T01:56:35.356Z DEBUG   038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-simpleclosed-chan#1: Closer tx stored by master: cd7ab089178298c65805a7fbe9392d7af00222a020d2a7c30066e89459d0df9c
lightningd-2 2026-07-14T01:56:35.356Z INFO    038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-chan#1: State changed from CLOSINGD_SIGEXCHANGE to CLOSINGD_COMPLETE
lightningd-1 2026-07-14T01:56:35.357Z DEBUG   033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-simpleclosed-chan#1: Closer tx stored by master: e3a50c499caaf8438abae6da9a2c0eb91c8284df99b7de99e14659d5d6b2c5b1
lightningd-1 2026-07-14T01:56:35.357Z INFO    033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-chan#1: State changed from CLOSINGD_SIGEXCHANGE to CLOSINGD_COMPLETE
lightningd-2 2026-07-14T01:56:35.363Z DEBUG   lightningd: Broadcasting txid cd7ab089178298c65805a7fbe9392d7af00222a020d2a7c30066e89459d0df9c
lightningd-2 2026-07-14T01:56:35.364Z DEBUG   lightningd: sendrawtransaction: 020000000101c6eb43de19b01f5dc1c1f3fb8e0c440131283392fabfa4138db2c0fcc4a130920000000000fdffffff02015ce7b963d37f8f2d51cafbba928aaa9e220b8bbc660571499c03628a3851b8ce0100000000000f40b00016001432c6b8ef183ca258f3080960541e05991d5e2342015ce7b963d37f8f2d51cafbba928aaa9e220b8bbc660571499c03628a3851b8ce01000000000000019000000000000000000400473044022005d2bb0dfc88dc0951c699b688e4d92e725c73abf8d1e7a302cca7ee0aec5eb702203a28a6f1e8973edf106024956973ecdcf1d26bb9eeb0757c78ebb63b278f1edd0147304402201b6c47d046b2813e65dc98be9305be93a05cd1daf6cbd232615ace23f5dd2af702200d014bcc9c5e268a1f329c093660eeb549caeaebd11324359cca77d6b0ce2c410147522102096e74aff8b917448bf683a9e60058194a77bfea42360f8ad2434763dd63527c21025b93ec4849eec35a35063a7e449c22a85940ececea6d0f40723f7b5f5afc9b6852ae0000000000
lightningd-2 2026-07-14T01:56:35.367Z DEBUG   hsmd: Client: Received message 5 from client
lightningd-2 2026-07-14T01:56:35.369Z DEBUG   038194b5f32bdf0aa59812c86c4ef7ad2f294104fa027d1ace9b469bb6f88cf37b-connectd: peer_downgrade
lightningd-1 2026-07-14T01:56:35.375Z DEBUG   wallet: Owning output 0 996225sat (p2wpkh) txid e3a50c499caaf8438abae6da9a2c0eb91c8284df99b7de99e14659d5d6b2c5b1
lightningd-1 2026-07-14T01:56:35.376Z DEBUG   lightningd: Broadcasting txid e3a50c499caaf8438abae6da9a2c0eb91c8284df99b7de99e14659d5d6b2c5b1 for "-c:close#40"
lightningd-1 2026-07-14T01:56:35.376Z DEBUG   lightningd: sendrawtransaction: 020000000101c6eb43de19b01f5dc1c1f3fb8e0c440131283392fabfa4138db2c0fcc4a130920000000000fdffffff02015ce7b963d37f8f2d51cafbba928aaa9e220b8bbc660571499c03628a3851b8ce0100000000000f33810016001432c6b8ef183ca258f3080960541e05991d5e2342015ce7b963d37f8f2d51cafbba928aaa9e220b8bbc660571499c03628a3851b8ce010000000000000ebf000000000000000004004730440220441c7b07b276660351b70c1d4645877e6f93f1f81e90ef0e7d85e5fbb21f0f4602203e9f9db614cf0d7fa690b43f6795c3460668b5214659568f68706c046f50eb8d0147304402202915dcef5e272e0b92b465e14b713c62a194bcae6adb3d1eb4fd3177592b8d94022076a6df80c445224f43991f63b4fd6aa571b8cd0d6cb1baf1dfdf49720b445b0f0147522102096e74aff8b917448bf683a9e60058194a77bfea42360f8ad2434763dd63527c21025b93ec4849eec35a35063a7e449c22a85940ececea6d0f40723f7b5f5afc9b6852ae0000000000
lightningd-1 2026-07-14T01:56:35.377Z DEBUG   hsmd: Client: Received message 5 from client
lightningd-1 2026-07-14T01:56:35.383Z DEBUG   033845802d25b4e074ccfd7cd8b339a41dc75bf9978a034800444b51d42b07799a-connectd: peer_downgrade
lightningd-2 2026-07-14T01:56:35.392Z DEBUG   plugin-bcli: sendrawtx exit 0 (elements-cli -chain=liquid-regtest -datadir=/tmp/ltests-oq0funbk/test_simple_close_dust_output_omitted_1/lightning-2/ -rpcclienttimeout=60 -rpcport=55659 -rpcuser=... -stdinrpcpass -stdin sendrawtransaction 020000000101c6eb43de19b01f5dc1c1f3fb8e0c440131283392fabfa4138db2c0fcc4a130920000000000fdffffff02015ce7b963d37f8f2d51cafbba928aaa9e220b8bbc660571499c03628a3851b8ce0100000000000f40b00016001432c6b8ef183ca258f3080960541e05991d5e2342015ce7b963d37f8f2d51cafbba928aaa9e220b8bbc660571499c03628a3851b8ce01000000000000019000000000000000000400473044022005d2bb0dfc88dc0951c699b688e4d92e725c73abf8d1e7a302cca7ee0aec5eb702203a28a6f1e8973edf106024956973ecdcf1d26bb9eeb0757c78ebb63b278f1edd0147304402201b6c47d046b2813e65dc98be9305be93a05cd1daf6cbd232615ace23f5dd2af702200d014bcc9c5e268a1f329c093660eeb549caeaebd11324359cca77d6b0ce2c410147522102096e74aff8b917448bf683a9e60058194a77bfea42360f8ad2434763dd63527c21025b93ec4849eec35a35063a7e449c22a85940ececea6d0f40723f7b5f5afc9b6852ae0000000000) 
{'run_id': 335237234731741184, 'github_repository': 'ElementsProject/lightning', 'github_sha': '4aae26dc3967ded5c2d1a4eec57a2c88aba2027d', 'github_ref': 'refs/heads/master', 'github_ref_name': 'master', 'github_run_id': 29298083244, 'github_head_ref': '', 'github_run_number': 17123, 'github_base_ref': '', 'github_run_attempt': '1', 'testname': 'test_simple_close_dust_output_omitted', 'start_time': 1783994190, 'end_time': 1783994195, 'outcome': 'fail'}
--------------------------- Captured stdout teardown ---------------------------
lightningd-1 2026-07-14T01:56:35.401Z DEBUG   plugin-bcli: sendrawtx exit 0 (elements-cli -chain=liquid-regtest -datadir=/tmp/ltests-oq0funbk/test_simple_close_dust_output_omitted_1/lightning-1/ -rpcclienttimeout=60 -rpcport=57743 -rpcuser=... -stdinrpcpass -stdin sendrawtransaction 020000000101c6eb43de19b01f5dc1c1f3fb8e0c440131283392fabfa4138db2c0fcc4a130920000000000fdffffff02015ce7b963d37f8f2d51cafbba928aaa9e220b8bbc660571499c03628a3851b8ce0100000000000f33810016001432c6b8ef183ca258f3080960541e05991d5e2342015ce7b963d37f8f2d51cafbba928aaa9e220b8bbc660571499c03628a3851b8ce010000000000000ebf000000000000000004004730440220441c7b07b276660351b70c1d4645877e6f93f1f81e90ef0e7d85e5fbb21f0f4602203e9f9db614cf0d7fa690b43f6795c3460668b5214659568f68706c046f50eb8d0147304402202915dcef5e272e0b92b465e14b713c62a194bcae6adb3d1eb4fd3177592b8d94022076a6df80c445224f43991f63b4fd6aa571b8cd0d6cb1baf1dfdf49720b445b0f0147522102096e74aff8b917448bf683a9e60058194a77bfea42360f8ad2434763dd63527c21025b93ec4849eec35a35063a7e449c22a85940ececea6d0f40723f7b5f5afc9b6852ae0000000000) 
lightningd-1 2026-07-14T01:56:36.222Z DEBUG   gossipd: REPLY WIRE_GOSSIPD_DEV_MEMLEAK_REPLY with 0 fds
lightningd-1 2026-07-14T01:56:36.222Z DEBUG   connectd: REPLY WIRE_CONNECTD_DEV_MEMLEAK_REPLY with 0 fds
lightningd-1 2026-07-14T01:56:37.180Z UNUSUAL lightningd: JSON-RPC shutdown

https://github.com/ElementsProject/lightning/actions/runs/29298083244/job/86980460165

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions