doc: fix wording for fundchannel_complete#2984
Merged
niftynei merged 1 commit intoAug 23, 2019
Merged
Conversation
ZmnSCPxj
reviewed
Aug 21, 2019
ZmnSCPxj
left a comment
ZmnSCPxj
left a comment
Contributor
There was a problem hiding this comment.
Looks OK to me. Suggest additional verbiage about fundchannel_start and fundchannel_complete being low-level operations that should not be used lightly and that incorrect usage can lead to permanent loss of funds.
Contributor
|
Also better to wait for #2936 also, as that changes the format of the manpages from Asciidoc to Markdown. |
niftynei
approved these changes
Aug 21, 2019
Contributor
|
Hi @meeDamian, as #2936 has merged, can you remake the commit to change the |
meeDamian
force-pushed
the
fix-fundchannel_complete-wording
branch
from
36ed5ef to
985e4cb
Compare
Contributor
Author
|
Rebased to the new format, and added likely-loss-of-funds notes in both commands. |
darosior
approved these changes
Aug 22, 2019
Contributor
|
ACK 985e4cb |
Collaborator
|
ACK 985e4cb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #2983 (comment).