Test penalty transaction accounting from both the punisher and the cheater peer perspective#8860
Open
enaples wants to merge 3 commits into
Open
Test penalty transaction accounting from both the punisher and the cheater peer perspective#8860enaples wants to merge 3 commits into
enaples wants to merge 3 commits into
Conversation
madelinevibes
added
the
QA
cdecker
force-pushed
the
test-penalty-accounting
branch
from
May 4, 2026 10:12
37639d4 to
33351a5
Compare
Member
|
Rebased on top of |
madelinevibes
added
Status::Ready for Review
enaples
force-pushed
the
test-penalty-accounting
branch
from
May 6, 2026 13:00
33351a5 to
53342b1
Compare
madelinevibes
force-pushed
the
test-penalty-accounting
branch
from
June 18, 2026 03:07
53342b1 to
f86f1d4
Compare
cdecker
force-pushed
the
test-penalty-accounting
branch
from
July 9, 2026 15:28
f86f1d4 to
33351a5
Compare
Member
|
Rebased again, happy to merge as soon as it passes. |
enaples
force-pushed
the
test-penalty-accounting
branch
from
July 10, 2026 08:48
40a09ea to
f4ebdc8
Compare
cdecker
force-pushed
the
test-penalty-accounting
branch
3 times, most recently
from
July 15, 2026 11:17
172444a to
67d75a4
Compare
cdecker
requested changes
Jul 15, 2026
cdecker
left a comment
cdecker
left a comment
Member
There was a problem hiding this comment.
There are a number of lint errors in the newly added tests. Please address them and we can merge this asap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
26.04 FREEZE March 11th: Non-bugfix PRs not ready by this date will wait for 26.06.
RC1 is scheduled on March 23rd
The final release is scheduled for April 15th.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
tools/lightning-downgradeRequested Info
It it correct that, from the bookkeeper perspective, the penalty transaction is recorded on the channel account and not on the wallet account?
Changelog-None