Fix xpay age flakyness#9214
Merged
madelinevibes merged 2 commits intoJun 17, 2026
Merged
Conversation
Lagrang3
force-pushed
the
fix-xpay-age-flakyness
branch
from
ebc5dc2 to
6c4cb66
Compare
Collaborator
|
Not super familiar with xpay but this looks fine to me and clears CI 👍 ACK 6c4cb66 |
madelinevibes
force-pushed
the
fix-xpay-age-flakyness
branch
from
6c4cb66 to
1c577de
Compare
preapproveinvoice_succeed and preapprovekeysend_succeed do the same thing: acknowledge that preapproval rpc call have succeeded and continue the payment execution via populate_private_layers. Therefore we use a unique function for both cases: preapprove_succeed. Changelog-None. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
We use to call askrene-age on xpay layer every 60 seconds to remove old entries. But for payments to discard old entries it is enough to call askrene-age before getroutes. True as long as: age(t1) * age(t2) * ... * age(tN) = age(tN) Reduces flakyness caused by xpay failing to call askrene-age during lightningd shutdown. Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
daywalker90
force-pushed
the
fix-xpay-age-flakyness
branch
from
1c577de to
d1b7a99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use to call askrene-age on xpay layer every 60 seconds to remove old
entries. But for payments to discard old entries it is enough to call
askrene-age before getroutes. True as long as:
Fixes #9210.