Update to nightly-2022-12-18#982
Conversation
|
The mergify stuff we forgot to fully remove is the only thing passing, actual GHA looks busted. EDIT: phew, that did actually work. |
|
Guess this brought in a $ rustfmt --check tests/ui/**/*.rs
Diff in /home/runner/work/rust-gpu/rust-gpu/tests/ui/image/format.rs at line 5: #[spirv(fragment)]
pub fn main(
- #[spirv(descriptor_set = 0, binding = 0)] image: &Image!(2D, format=rgba32f, sampled),
+ #[spirv(descriptor_set = 0, binding = 0)] image: &Image!(2D, format = rgba32f, sampled),
output: &mut glam::Vec4,
) {
let texel = image.fetch(glam::IVec2::new(0, 1)); |
|
And apparently a |
There was a problem hiding this comment.
I found several instances of "{}", " - that indicates likely a bad replacement, where instead of formatting, you're printing the format string verbatim.
This is likely due to the editions, maybe we need to revive a partial version of my PR to switch to Rust 2021.
|
Looks like clippy got fixed in: which got sync'd into So theoretically updating to Alternatively, we could |
|
I'll try updating to |
This nightly includes a clippy fix that we need (rust-lang/rust-clippy#10055)
This brings us on par with 1.67 due for release on January 26.