You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Android - Log in - Can't log in from Magic link in Email #100257
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug (client-side — native Android / HybridApp layer; the fix is not in an Expensify/App JS PR) Causing PR: No Expensify/App PR on the 9.4.69-0 checklist touches the magic-link / deep-link sign-in path. The only change in production...staging that can affect Android intent handling is the Mobile-Expensify submodule bump f72dc07 → 3ac8c5c, which carries Mobile-Expensify#14097 (Medium confidence — I do not have read access to that repo, so I could not diff it). Related Issues: #100246 and #100256 — both Android-app-only, both staging-only, both filed by Applause against the same Mobile-Expensify#14097 build, and both are launcher-intent / deep-link routing failures. Three intent-routing regressions in one release with a single native change is the strongest signal here.
Recommendation: NEEDS INVESTIGATION
I can rule out every App PR in this release with high confidence, but I cannot read Mobile-Expensify to confirm the native change, so I'm stopping short of naming it as the definitive cause. If the owners of Mobile-Expensify#14097 can't produce a quick fix, rolling the submodule pointer back to f72dc07 is the way to unblock the deploy.
Assigned: none — the suspected change is in Mobile-Expensify and I can't resolve its author/reviewers from here. Please pull in the author and approvers of Mobile-Expensify#14097. cc @marcaaron@AndrewGable Labels: No changes. DeployBlockerCash is kept (this ships with the App/HybridApp deploy and is not reproducible on production). DeployBlocker was not present, so nothing was removed.
📋 Detailed Analysis
Evidence
1. The magic-link sign-in code path is essentially untouched in this release.
The full production...staging diff for 9.4.69-0 contains only these sign-in-adjacent files:
The magic-link deep-link flow calls signInWithValidateCode(accountID, validateCode, preferredLocale) with notwoFactorAuthCode argument (Session/index.ts#L1555-L1562), so twoFactorAuthCode defaults to '', the guard is false, and params is byte-for-byte what production sends. The rest of the PR is a new optional field on a params type, a new optional field on the Credentials Onyx type, one extra argument threaded through BaseValidateCodeForm, and tests. Nothing in it is platform-specific, so it also can't explain "Android only".
3. No other App PR in the release goes anywhere near deep links, routing, or auth. I checked the file list of every non-docs PR on the checklist:
The only remaining changes to src/setup/index.ts and src/ONYXKEYS.ts come from the Revert "Add intl deposit account collection" commit (6a5922f), which is deposit-account collection keys.
4. The Android side of the App repo did not change. The only android/ change in the whole release is a version bump in android/app/build.gradle (9.4.66-0 → 9.4.69-0). AndroidManifest.xml is not in the diff — the /v App Link intent filter is identical to production (AndroidManifest.xml#L78, plus the staging host at L102). The JS-side deep-link subscriber (linkingConfig/subscribe.ts#L40) is also unchanged.
5. Staging-only + Android-app-only + two sibling regressions with the same shape. Not reproducible on production, not reproducible on any other platform. The only native delta between 9.4.68-1 (production) and 9.4.69-0 (staging) is the Mobile-Expensify submodule bump. #100246 (launcher shortcut → scan receipt doesn't route) and #100256 (Switch to Expensify Classic opens mWeb instead of staying in-app) are the same class of failure — an incoming intent/URL not being routed to the right destination — and both bug reports name Mobile-Expensify#14097 as the build under test.
Confirmed via gh api repos/Expensify/App/compare/production...staging that no file under src/pages/signin/ other than BaseValidateCodeForm.tsx, no file under src/libs/Navigation/, and no Android manifest or native module changed.
Confirmed the line numbers above against the staging tree at c9dd46f6704956e162eb4dd42469aa98bfbffcf3.
Could not verify the Mobile-Expensify submodule change: Expensify/Mobile-Expensify is not readable from this environment (404 on both the repo and PR Update version to 1.2.50-10 on staging #14097), and the submodule directory is empty in this checkout. This is the reason the confidence is Medium rather than High, and the reason this is NEEDS INVESTIGATION rather than a straight REVERT.
Root Cause
Best hypothesis, pending someone who can read the native diff: the magic-link URL (https://new.expensify.com/v/<accountID>/<validateCode>) is either not being matched by the HybridApp's Android intent filter or is not being forwarded from the native launch/onNewIntent handler into the NewDot linking layer. ValidateLoginPage therefore never mounts, signInWithValidateCode is never dispatched, session.autoAuthState stays NOT_STARTED, and the app just sits on the already-visible "Enter Magic Code" screen — exactly the reported behaviour. Note the symptom is "nothing happens" rather than an error: a failed SignInUserWithLink would set autoAuthState: FAILED and trigger a Navigation.goBack(), so the evidence points at the intent never reaching JS at all rather than at a failing API call.
Activity
applause-bot commentedon Sep 3, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/5f62d7eb2cb97931181d56e2cc3d7ac640ffc34ae4e89dce60a29a8eb944d3eb
melvin-bot commentedon Sep 3, 2026
Triggered auto assignment to @marcaaron (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Sep 3, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Sep 3, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Sep 3, 2026
🔍 Investigation Summary
Classification: Frontend bug (client-side — native Android / HybridApp layer; the fix is not in an
Expensify/AppJS PR)Causing PR: No
Expensify/AppPR on the9.4.69-0checklist touches the magic-link / deep-link sign-in path. The only change inproduction...stagingthat can affect Android intent handling is the Mobile-Expensify submodule bumpf72dc07→3ac8c5c, which carries Mobile-Expensify#14097 (Medium confidence — I do not have read access to that repo, so I could not diff it).Related Issues: #100246 and #100256 — both Android-app-only, both staging-only, both filed by Applause against the same Mobile-Expensify#14097 build, and both are launcher-intent / deep-link routing failures. Three intent-routing regressions in one release with a single native change is the strongest signal here.
Recommendation: NEEDS INVESTIGATION
I can rule out every App PR in this release with high confidence, but I cannot read Mobile-Expensify to confirm the native change, so I'm stopping short of naming it as the definitive cause. If the owners of Mobile-Expensify#14097 can't produce a quick fix, rolling the submodule pointer back to
f72dc07is the way to unblock the deploy.Assigned: none — the suspected change is in Mobile-Expensify and I can't resolve its author/reviewers from here. Please pull in the author and approvers of Mobile-Expensify#14097. cc @marcaaron @AndrewGable
Labels: No changes.
DeployBlockerCashis kept (this ships with the App/HybridApp deploy and is not reproducible on production).DeployBlockerwas not present, so nothing was removed.📋 Detailed Analysis
Evidence
1. The magic-link sign-in code path is essentially untouched in this release.
The full
production...stagingdiff for9.4.69-0contains only these sign-in-adjacent files:src/libs/API/parameters/SignInUserParams.tssrc/libs/API/parameters/SignInUserWithLinkParams.tssrc/libs/actions/Session/index.tssrc/pages/signin/ValidateCodeForm/BaseValidateCodeForm.tsxsrc/types/onyx/Credentials.tsAll five come from one PR: #100084 "[No QA] Pass authtoken back through SignInUser" by @NikkiWines.
2. #100084 cannot produce this symptom. Its entire runtime effect is gated behind a 2FA code being present:
Session/index.ts#L964-L968—if (twoFactorAuthCode && storedAuthToken) { params.authToken = storedAuthToken; }insignIn()Session/index.ts#L1046-L1048— the same guard insignInWithValidateCode()The magic-link deep-link flow calls
signInWithValidateCode(accountID, validateCode, preferredLocale)with notwoFactorAuthCodeargument (Session/index.ts#L1555-L1562), sotwoFactorAuthCodedefaults to'', the guard is false, andparamsis byte-for-byte what production sends. The rest of the PR is a new optional field on a params type, a new optional field on theCredentialsOnyx type, one extra argument threaded throughBaseValidateCodeForm, and tests. Nothing in it is platform-specific, so it also can't explain "Android only".3. No other App PR in the release goes anywhere near deep links, routing, or auth. I checked the file list of every non-docs PR on the checklist:
SequentialQueue.ts— but the new logic is scoped toReadNewestAction/AddComment/AddAttachmentcommands only, and never runs forSignInUserWithLinkactions/OnyxDerived/index.tsonlyuseOnyxrename + Search/Category call sitesThe only remaining changes to
src/setup/index.tsandsrc/ONYXKEYS.tscome from theRevert "Add intl deposit account collection"commit (6a5922f), which is deposit-account collection keys.4. The Android side of the App repo did not change. The only
android/change in the whole release is a version bump inandroid/app/build.gradle(9.4.66-0→9.4.69-0).AndroidManifest.xmlis not in the diff — the/vApp Link intent filter is identical to production (AndroidManifest.xml#L78, plus the staging host at L102). The JS-side deep-link subscriber (linkingConfig/subscribe.ts#L40) is also unchanged.5. Staging-only + Android-app-only + two sibling regressions with the same shape. Not reproducible on production, not reproducible on any other platform. The only native delta between
9.4.68-1(production) and9.4.69-0(staging) is the Mobile-Expensify submodule bump. #100246 (launcher shortcut → scan receipt doesn't route) and #100256 (Switch to Expensify Classic opens mWeb instead of staying in-app) are the same class of failure — an incoming intent/URL not being routed to the right destination — and both bug reports name Mobile-Expensify#14097 as the build under test.Verification
src/pages/ValidateLoginPage/index.tsx#L24-L40→signInWithValidateCodeAndNavigate→signInWithValidateCode. Neither file was modified in this release except for the 2FA-gated additions above.gh api repos/Expensify/App/compare/production...stagingthat no file undersrc/pages/signin/other thanBaseValidateCodeForm.tsx, no file undersrc/libs/Navigation/, and no Android manifest or native module changed.c9dd46f6704956e162eb4dd42469aa98bfbffcf3.Expensify/Mobile-Expensifyis not readable from this environment (404on both the repo and PR Update version to 1.2.50-10 on staging #14097), and the submodule directory is empty in this checkout. This is the reason the confidence is Medium rather than High, and the reason this isNEEDS INVESTIGATIONrather than a straightREVERT.Root Cause
Best hypothesis, pending someone who can read the native diff: the magic-link URL (
https://new.expensify.com/v/<accountID>/<validateCode>) is either not being matched by the HybridApp's Android intent filter or is not being forwarded from the native launch/onNewIntenthandler into the NewDot linking layer.ValidateLoginPagetherefore never mounts,signInWithValidateCodeis never dispatched,session.autoAuthStatestaysNOT_STARTED, and the app just sits on the already-visible "Enter Magic Code" screen — exactly the reported behaviour. Note the symptom is "nothing happens" rather than an error: a failedSignInUserWithLinkwould setautoAuthState: FAILEDand trigger aNavigation.goBack(), so the evidence points at the intent never reaching JS at all rather than at a failing API call.Next steps
f72dc07and re-cut. That is cheaper than reverting any App PR, none of which are implicated.view run
war-in commentedon Sep 3, 2026
I think this investigation applies here too - #100246 (comment)Turned out to be related to https://github.com/Expensify/Mobile-Expensify/pull/14097
AndrewGable commentedon Sep 3, 2026
The linked Mobile-Expensify PR is reverted on staging and we are retesting it now.
IuliiaHerets commentedon Sep 3, 2026
Issue is not reproducible in the latest build
screen-20260903-194630-1788453979486.mp4
marcaaron commentedon Sep 17, 2026
Seems like we can close this? Please reopen if that's incorrect.