Skip to content

Knip misidentifies Bun shell arguments as binaries #100330

Closed

Description

@MelvinBot

Problem

Knip 6.14.0 parses each static fragment of an interpolated Bun shell template as a standalone command. In benchmarking PR #98144, the command $`${ghExecutable} api user --jq .login` therefore makes Knip treat api as an undeclared executable. This causes the Knip workflow to fail even though api is an argument passed to the gh CLI.

This is the same parsing limitation reported in webpro-nl/knip#1867. It blocks the benchmarking PR from using Bun shell naturally unless command arguments are incorrectly added to ignoreBinaries.

Solution

Update Knip to 6.34.0 in PR #100329. Knip fixed interpolated Bun shell parsing in version 6.25.0 by reconstructing the entire tagged template before extracting binaries, and the current release includes that fix. The update also recognizes gh as a system executable, so the benchmarking PR only needs to ignore binaries that Knip cannot identify itself.

Upstream fix: webpro-nl/knip@9422d06

Activity

  1. melvin-bot commented on Sep 8, 2026

    @melvin-bot

    @chrispader

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.73-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

  2. melvin-bot commented on Sep 11, 2026

    @melvin-bot

    @chrispader Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  3. chrispader commented on Sep 14, 2026

    @chrispader
    Contributor

    @roryabraham since no C+ was involved, i think we can close this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions