You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-16] [$175] [CFI] Description hint is not displayed in the description field. #100527
Version Number: v9.4.72-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/13176708/test-cases/41236896 Email or phone of affected tester (no customers):dave0123seife@gmail.com Issue reported by: Applause Internal Team Bug source: Regression TC Execution Device used: Mac 14.5/ Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Enabled rules in Workspace
Steps:
Go to Workspace > Categories > Advertising
Add a Description Hint > Save
Go to Required fields > Enable Require description
4 Start manual Expense creation flow > Enter Amount
Choose Advertising as Category
Expected Result:
Added description hint is displayed in the description field after choosing the Category
Hint Text Specs
Size: Label (13px/16px)
Color: textSupporting
Position: 4px below the input field
Actual Result:
Description hint is not displayed in the description field.
The description field on the new manual expense creation form never receives the category's hint.
In the new manual expense flow, the description is an inline TextInput rendered by src/components/MoneyRequestConfirmationList/sections/DescriptionField.tsx:102-121. That input is given label and accessibilityLabel but no hint prop, so policyCategory.commentHint has nowhere to render. The old flow's MenuItemWithTopDescription branch has no hint either — it only adds a "Required" right label.
The hint is wired up in exactly one place in the app: the standalone description screen, src/pages/iou/request/step/DynamicIOURequestStepDescription.tsx:181. In the new flow that screen is never opened for description during creation, which is why the hint appears when you edit an existing expense but not while creating one.
Confirmed by repro on dev web (v9.4.72-2 line) + a secondary bug in the old flow
Repro (web, Chrome): Collect→Control workspace, Advertising category with hint Client name and Require description on.
Step
Result
Hint saved on category settings
✅
Require description enabled
✅
Creation flow, category chosen — Description field shows only the generic Description placeholder, no hint
❌
Editing description of the already-created expense — hint Client name renders under the input
✅ (works)
Secondary bug, same symptom, old flow only.DynamicIOURequestStepDescription reads categories from the route report's policy — useOnyx(POLICY_CATEGORIES + report?.policyID) at line 72. During creation that route report is not the workspace chat: the FAB seeds a generateReportID() with no Onyx report (FloatingActionButtonAndPopover.tsx:36), and with delayed submissions off the amount step hands confirmation the self-DM, whose policyID is _FAKE_ (IOUAmountSubmission.ts:504-517). Either way policyCategories is undefined and line 181 silently yields ''. The sibling category step already solves this — it resolves the policy from the transaction/participants with a draft fallback (DynamicIOURequestStepCategory.tsx:77-108), which is why you can pick the category but then can't see its hint.
transaction.category itself is fine — action === CREATE makes withFullTransactionOrNotFound pass the draft transaction (withFullTransactionOrNotFound.tsx:127), and the category step writes category to TRANSACTION_DRAFT.
The hint was added in #56317, whose test steps did cover "before they create the expense". The original commit special-cased the draft transaction for that, but the policyCategories subscription was always keyed on report?.policyID and was never made creation-aware; the new inline flow then bypassed the screen entirely.
What changes do you think we should make in order to solve the problem?
1. Render the hint on the inline description input (fixes the reported flow).
In DescriptionField.tsx, derive the hint and pass it to the TextInput:
Read the transaction's category with the existing categoryStateSelector via useTransactionSelector — the same pattern CategoryField.tsx:56 uses.
Read the policy's categories with usePolicyCategoriesForConfirmation(policy?.id) — the hook MoneyRequestConfirmationList already uses at line 221.
Keeping the lookup inside DescriptionField avoids threading a new value through requiredFlags and the four footer variants. Alternatively, compute it next to isDescriptionRequired at MoneyRequestConfirmationList.tsx:380, where policyCategories and iouCategory are already in hand, and add it to requiredFlags.
2. Make the description screen's policy lookup creation-aware (fixes the old flow and any entry point where the route report isn't the workspace chat).
Replace the report?.policyID key at DynamicIOURequestStepDescription.tsx:72 with the same resolution the category step uses: getSelectedWorkspacePolicyID(transaction, action) ?? getIOURequestPolicyID(transaction, pickReportForPolicy(...)), plus the POLICY_CATEGORIES_DRAFT fallback.
Tests: unit-test the hint derivation for a category with a commentHint against one without, and add a creation-flow case asserting the hint renders after a category with a hint is selected.
What alternative solutions did you explore? (Optional)
Show the hint on the confirmation Description row itself (the old flow's MenuItemWithTopDescription). It has no hint slot today, in any flow or action, so this is a product decision rather than a bug fix — worth a design call if it's wanted.
Prefill the description with the hint text. Rejected: the copy is a prompt ("Client name"), not a value, and it would submit hint text as real data.
Related issues and one loose end
No duplicate found. #98740 (markdown formatting in the description-hint change log) touches the same feature but is a different bug.
Loose end, not reproduced: for isEditingSplit the description screen reads transaction.category rather than splitDraftTransaction.category, unlike DynamicIOURequestStepCategory.tsx:111-112. Likely a third, narrower hint gap.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/100527) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
Please re-state the problem that we are trying to solve in this issue.
In a workspace with Rules enabled and "Require description" enabled on a category with a configured Description Hint (e.g. "Client name"), starting the manual expense creation flow and choosing that category results in the Description field showing only the generic "Description" label/placeholder with no hint text displayed.
What is the root cause of that problem?
There are two root causes across the expense creation surfaces:
Inline Description Input (DescriptionField.tsx):
In the new manual expense creation flow (isNewManualExpenseFlowEnabled = true), DescriptionField.tsx renders an inline TextInput inside MoneyRequestConfirmationList. However, TextInput is rendered without passing any hint or shouldRenderHintAsHTML props:
DescriptionField receives policy as a prop and has transactionID from useConfirmationFields(), but currently does not look up the selected category or its corresponding commentHint from policy categories.
Dedicated Description Screen (DynamicIOURequestStepDescription.tsx):
In legacy or navigation-based flows where the user taps MenuItemWithTopDescription, DynamicIOURequestStepDescription.tsx attempts to compute descriptionHint:
During manual expense creation, the route report is often a temporary generated report without a saved Onyx policy, or a self-DM with a fake policy ID (_FAKE_). As a result, policyCategories is undefined, causing descriptionHint to evaluate to ''.
What changes do you think we should make in order to solve the problem?
1. In src/components/MoneyRequestConfirmationList/sections/DescriptionField.tsx:
Import categoryStateSelector from ./selectors.
Import usePolicyCategoriesForConfirmation from @components/MoneyRequestConfirmationList/hooks/usePolicyCategoriesForConfirmation.
Retrieve the transaction's selected category using the existing selector:
2. In src/pages/iou/request/step/DynamicIOURequestStepDescription.tsx:
Update the policy resolution to match DynamicIOURequestStepCategory.tsx:
Resolve policyID using getSelectedWorkspacePolicyID(transaction, action) ?? getIOURequestPolicyID(transaction, pickReportForPolicy(report, transactionReport, participantReport)) with fallback to reportDraft.
Subscribe to both real and draft policy categories:
This ensures that when navigating to the full-page description step during creation, policyCategories is populated and descriptionHint renders accurately.
3. Automated Tests:
Add unit tests in tests/unit/components/MoneyRequestConfirmationList/DescriptionFieldTest.tsx:
Verify that when a transaction has a category with a configured commentHint, TextInput receives the expected hint string and shouldRenderHintAsHTML = true.
Verify that when a transaction has no category, or a category without a commentHint, hint is empty and shouldRenderHintAsHTML = false.
Add unit test in tests/unit/DynamicIOURequestStepDescriptionTest.tsx:
Verify that descriptionHint resolves correctly even when report.policyID is empty during draft creation.
What alternative solutions did you explore? (Optional)
Passing descriptionHint down as a prop from MoneyRequestConfirmationList through requiredFlags into TransactionDetailsFields and DescriptionField. However, computing it directly within DescriptionField via useTransactionSelector and usePolicyCategoriesForConfirmation is cleaner, keeps concerns encapsulated, and matches how sibling fields like CategoryField and MerchantField operate without bloating intermediate wrapper components.
@Ollyws Worth flagging while this is being scoped, because the same branch drops a second thing and it is tied to the "Require description" half of the repro.
DescriptionField is handed isDescriptionRequired all the way from MoneyRequestConfirmationList:
Description has neither. For completeness on where the requirement is enforced: useConfirmationValidation has no reference to description at all, so confirmation is not blocked, and the requirement surfaces afterwards as the missingComment violation. Amount, date and merchant each have a branch in that file.
So with rules on and Require description enabled, the new flow shows the field with no hint and no "Required" marker. The hint and the marker are the same three lines of JSX, so it is worth deciding up front whether this issue covers both or only the hint.
📣 @badnikhil! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
Please re-state the problem that we are trying to solve in this issue.
With a category rule that sets a description hint (and "Require description" on), creating a manual expense shows the description field with no hint and no Required marker.
What is the root cause of that problem?
In the new manual expense flow (isBetaEnabled(CONST.BETAS.NEW_MANUAL_EXPENSE_FLOW), MoneyRequestConfirmationList.tsx:227) the description is an inline TextInput rendered by DescriptionField.tsx:102-121.
The hint lives at policyCategory.commentHint (src/types/onyx/PolicyCategory.ts:41) and is rendered in exactly one place in the app: DynamicIOURequestStepDescription.tsx:181 computes
and passes it as hint with shouldRenderHintAsHTML. The new flow never opens that screen while creating the expense, so the hint has nowhere to render.
Two details worth having on the record, because they change the scope:
The same JSX branch also drops the Required affordance. isDescriptionRequired is handed all the way down from MoneyRequestConfirmationList through TransactionDetailsFields/index.tsx:98, but the inline branch never reads it — the Required label only exists on the menu-item branch below (DescriptionField.tsx:102 vs :141). MerchantField has the identical shape and handled it: its inline branch drops rightLabel and puts an inline error in its place (MerchantField.tsx:129, :153). Description has neither. So the tester's repro is really two regressions in the same ternary.
useConfirmationValidation has no reference to description at all, so confirmation is never blocked; the requirement only surfaces afterwards as the missingComment violation. Amount, date and merchant each have a branch in that file.
What changes do you think we should make in order to solve the problem?
The parent already holds both halves of the lookup, so no new Onyx subscription and no new plumbing are needed. MoneyRequestConfirmationList.tsx:380 already computes isCategoryDescriptionRequired(policyCategories, iouCategory, ...) from the same policyCategories and the same category.
In MoneyRequestConfirmationList.tsx, next to line 380, derive
and add it to the existing requiredFlags object at line 597. It already flows to DescriptionField via fieldGroupTypes.ts:32 and TransactionDetailsFields/index.tsx:98.
In DescriptionField.tsx, on the inline TextInput, pass hint={descriptionHint} and shouldRenderHintAsHTML={!!descriptionHint}, mirroring DynamicIOURequestStepDescription.tsx:232-233, and render the Required affordance from the isDescriptionRequired prop so it stops being dead in that branch.
Jest test: a category with a commentHint renders it, one without renders nothing, and isDescriptionRequired renders the marker.
What alternative solutions did you explore? (Optional)
Reading commentHint inside DescriptionField from its own Onyx connection. Rejected: it duplicates a lookup the parent already performs and adds a subscription per field.
Routing creation through DynamicIOURequestStepDescription so the existing hint code runs. Rejected: that reintroduces the extra screen the new flow deliberately removes.
Fixing only the hint and leaving Required dead. Worth a maintainer decision rather than my assumption, which is why I flagged it above; the two are the same three lines of JSX, so splitting them costs a second PR.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: N/A, new feature.
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template. Needed for all bugs AND new features
Regression Test Proposal
Precondition:
Rules are enabled in the workspace
Test:
Precondition:
1. Go to Workspace > Categories > Advertising
2. Add a Description hint > Save
3. Go to Required fields > Enable Require description
4. Start the manual expense creation flow > Enter an amount
5. Choose Advertising as the category
6. Verify the description hint is displayed in the Description field after choosing the category
Activity
applause-bot commentedon Sep 7, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/e929e2648a4152b402d01d9b942884ef366b07bf8cfba7e8bc7c83ff2ddf78a8
MelvinBot commentedon Sep 7, 2026
Proposal
What is the root cause of that problem?
The description field on the new manual expense creation form never receives the category's hint.
In the new manual expense flow, the description is an inline
TextInputrendered bysrc/components/MoneyRequestConfirmationList/sections/DescriptionField.tsx:102-121. That input is givenlabelandaccessibilityLabelbut nohintprop, sopolicyCategory.commentHinthas nowhere to render. The old flow'sMenuItemWithTopDescriptionbranch has no hint either — it only adds a "Required" right label.The hint is wired up in exactly one place in the app: the standalone description screen,
src/pages/iou/request/step/DynamicIOURequestStepDescription.tsx:181. In the new flow that screen is never opened for description during creation, which is why the hint appears when you edit an existing expense but not while creating one.Confirmed by repro on dev web (v9.4.72-2 line) + a secondary bug in the old flow
Repro (web, Chrome): Collect→Control workspace,
Advertisingcategory with hintClient nameand Require description on.Descriptionplaceholder, no hintClient namerenders under the inputSecondary bug, same symptom, old flow only.
DynamicIOURequestStepDescriptionreads categories from the route report's policy —useOnyx(POLICY_CATEGORIES + report?.policyID)at line 72. During creation that route report is not the workspace chat: the FAB seeds agenerateReportID()with no Onyx report (FloatingActionButtonAndPopover.tsx:36), and with delayed submissions off the amount step hands confirmation the self-DM, whosepolicyIDis_FAKE_(IOUAmountSubmission.ts:504-517). Either waypolicyCategoriesisundefinedand line 181 silently yields''. The sibling category step already solves this — it resolves the policy from the transaction/participants with a draft fallback (DynamicIOURequestStepCategory.tsx:77-108), which is why you can pick the category but then can't see its hint.transaction.categoryitself is fine —action === CREATEmakeswithFullTransactionOrNotFoundpass the draft transaction (withFullTransactionOrNotFound.tsx:127), and the category step writescategorytoTRANSACTION_DRAFT.The hint was added in #56317, whose test steps did cover "before they create the expense". The original commit special-cased the draft transaction for that, but the
policyCategoriessubscription was always keyed onreport?.policyIDand was never made creation-aware; the new inline flow then bypassed the screen entirely.What changes do you think we should make in order to solve the problem?
1. Render the hint on the inline description input (fixes the reported flow).
In
DescriptionField.tsx, derive the hint and pass it to theTextInput:categoryStateSelectorviauseTransactionSelector— the same patternCategoryField.tsx:56uses.usePolicyCategoriesForConfirmation(policy?.id)— the hookMoneyRequestConfirmationListalready uses at line 221.commentHintfor that category and pass it ashint, withshouldRenderHintAsHTMLwhen non-empty, mirroringDynamicIOURequestStepDescription.tsx:232-233.Keeping the lookup inside
DescriptionFieldavoids threading a new value throughrequiredFlagsand the four footer variants. Alternatively, compute it next toisDescriptionRequiredatMoneyRequestConfirmationList.tsx:380, wherepolicyCategoriesandiouCategoryare already in hand, and add it torequiredFlags.2. Make the description screen's policy lookup creation-aware (fixes the old flow and any entry point where the route report isn't the workspace chat).
Replace the
report?.policyIDkey atDynamicIOURequestStepDescription.tsx:72with the same resolution the category step uses:getSelectedWorkspacePolicyID(transaction, action) ?? getIOURequestPolicyID(transaction, pickReportForPolicy(...)), plus thePOLICY_CATEGORIES_DRAFTfallback.Tests: unit-test the hint derivation for a category with a
commentHintagainst one without, and add a creation-flow case asserting the hint renders after a category with a hint is selected.What alternative solutions did you explore? (Optional)
MenuItemWithTopDescription). It has no hint slot today, in any flow or action, so this is a product decision rather than a bug fix — worth a design call if it's wanted.Related issues and one loose end
No duplicate found. #98740 (markdown formatting in the description-hint change log) touches the same feature but is a different bug.
Loose end, not reproduced: for
isEditingSplitthe description screen readstransaction.categoryrather thansplitDraftTransaction.category, unlikeDynamicIOURequestStepCategory.tsx:111-112. Likely a third, narrower hint gap.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/100527)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run · no recording available
melvin-bot commentedon Sep 7, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)melvin-bot commentedon Sep 7, 2026
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.
danielamodu commentedon Sep 7, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
In a workspace with Rules enabled and "Require description" enabled on a category with a configured Description Hint (e.g. "Client name"), starting the manual expense creation flow and choosing that category results in the Description field showing only the generic "Description" label/placeholder with no hint text displayed.
What is the root cause of that problem?
There are two root causes across the expense creation surfaces:
DescriptionField.tsx):In the new manual expense creation flow (
isNewManualExpenseFlowEnabled = true),DescriptionField.tsxrenders an inlineTextInputinsideMoneyRequestConfirmationList. However,TextInputis rendered without passing anyhintorshouldRenderHintAsHTMLprops:DescriptionFieldreceivespolicyas a prop and hastransactionIDfromuseConfirmationFields(), but currently does not look up the selected category or its correspondingcommentHintfrom policy categories.DynamicIOURequestStepDescription.tsx):In legacy or navigation-based flows where the user taps
MenuItemWithTopDescription,DynamicIOURequestStepDescription.tsxattempts to computedescriptionHint:However,
policyCategoriesis subscribed at line 72 using onlyreport?.policyID:During manual expense creation, the route
reportis often a temporary generated report without a saved Onyx policy, or a self-DM with a fake policy ID (_FAKE_). As a result,policyCategoriesisundefined, causingdescriptionHintto evaluate to''.What changes do you think we should make in order to solve the problem?
1. In
src/components/MoneyRequestConfirmationList/sections/DescriptionField.tsx:categoryStateSelectorfrom./selectors.usePolicyCategoriesForConfirmationfrom@components/MoneyRequestConfirmationList/hooks/usePolicyCategoriesForConfirmation.usePolicyCategoriesForConfirmation(policy?.id).hint={descriptionHint}andshouldRenderHintAsHTML={!!descriptionHint}toTextInput:2. In
src/pages/iou/request/step/DynamicIOURequestStepDescription.tsx:DynamicIOURequestStepCategory.tsx:Resolve
policyIDusinggetSelectedWorkspacePolicyID(transaction, action) ?? getIOURequestPolicyID(transaction, pickReportForPolicy(report, transactionReport, participantReport))with fallback toreportDraft.policyCategoriesis populated anddescriptionHintrenders accurately.3. Automated Tests:
tests/unit/components/MoneyRequestConfirmationList/DescriptionFieldTest.tsx:commentHint,TextInputreceives the expectedhintstring andshouldRenderHintAsHTML = true.commentHint,hintis empty andshouldRenderHintAsHTML = false.tests/unit/DynamicIOURequestStepDescriptionTest.tsx:descriptionHintresolves correctly even whenreport.policyIDis empty during draft creation.What alternative solutions did you explore? (Optional)
Passing
descriptionHintdown as a prop fromMoneyRequestConfirmationListthroughrequiredFlagsintoTransactionDetailsFieldsandDescriptionField. However, computing it directly withinDescriptionFieldviauseTransactionSelectorandusePolicyCategoriesForConfirmationis cleaner, keeps concerns encapsulated, and matches how sibling fields likeCategoryFieldandMerchantFieldoperate without bloating intermediate wrapper components.badnikhil commentedon Sep 8, 2026
@Ollyws Worth flagging while this is being scoped, because the same branch drops a second thing and it is tied to the "Require description" half of the repro.
DescriptionFieldis handedisDescriptionRequiredall the way fromMoneyRequestConfirmationList:https://github.com/Expensify/App/blob/378f5f8b4118ab0e0e6bcd6f38bf16a0361f6154/src/components/MoneyRequestConfirmationListFooter/fieldGroups/TransactionDetailsFields/index.tsx#L98
but in the new manual expense branch the prop is never read. The "Required" label only exists on the menu-item branch underneath it:
App/src/components/MoneyRequestConfirmationList/sections/DescriptionField.tsx
Line 102 in 378f5f8
App/src/components/MoneyRequestConfirmationList/sections/DescriptionField.tsx
Line 141 in 378f5f8
MerchantFieldhas the same shape but handled it. Its inline branch also dropsrightLabel, and puts an inline error in its place:App/src/components/MoneyRequestConfirmationList/sections/MerchantField.tsx
Line 129 in 378f5f8
App/src/components/MoneyRequestConfirmationList/sections/MerchantField.tsx
Line 153 in 378f5f8
Description has neither. For completeness on where the requirement is enforced:
useConfirmationValidationhas no reference to description at all, so confirmation is not blocked, and the requirement surfaces afterwards as themissingCommentviolation. Amount, date and merchant each have a branch in that file.So with rules on and Require description enabled, the new flow shows the field with no hint and no "Required" marker. The hint and the marker are the same three lines of JSX, so it is worth deciding up front whether this issue covers both or only the hint.
melvin-bot commentedon Sep 8, 2026
📣 @badnikhil! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
badnikhil commentedon Sep 8, 2026
Contributor details
Your Expensify account email: nikhilljatt@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01f2ba0507adf6ac64
melvin-bot commentedon Sep 8, 2026
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
badnikhil commentedon Sep 8, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
With a category rule that sets a description hint (and "Require description" on), creating a manual expense shows the description field with no hint and no
Requiredmarker.What is the root cause of that problem?
In the new manual expense flow (
isBetaEnabled(CONST.BETAS.NEW_MANUAL_EXPENSE_FLOW),MoneyRequestConfirmationList.tsx:227) the description is an inlineTextInputrendered byDescriptionField.tsx:102-121.The hint lives at
policyCategory.commentHint(src/types/onyx/PolicyCategory.ts:41) and is rendered in exactly one place in the app:DynamicIOURequestStepDescription.tsx:181computesand passes it as
hintwithshouldRenderHintAsHTML. The new flow never opens that screen while creating the expense, so the hint has nowhere to render.Two details worth having on the record, because they change the scope:
Requiredaffordance.isDescriptionRequiredis handed all the way down fromMoneyRequestConfirmationListthroughTransactionDetailsFields/index.tsx:98, but the inline branch never reads it — theRequiredlabel only exists on the menu-item branch below (DescriptionField.tsx:102vs:141).MerchantFieldhas the identical shape and handled it: its inline branch dropsrightLabeland puts an inline error in its place (MerchantField.tsx:129,:153). Description has neither. So the tester's repro is really two regressions in the same ternary.useConfirmationValidationhas no reference to description at all, so confirmation is never blocked; the requirement only surfaces afterwards as themissingCommentviolation. Amount, date and merchant each have a branch in that file.What changes do you think we should make in order to solve the problem?
The parent already holds both halves of the lookup, so no new Onyx subscription and no new plumbing are needed.
MoneyRequestConfirmationList.tsx:380already computesisCategoryDescriptionRequired(policyCategories, iouCategory, ...)from the samepolicyCategoriesand the same category.MoneyRequestConfirmationList.tsx, next to line 380, deriveand add it to the existing
requiredFlagsobject at line 597. It already flows toDescriptionFieldviafieldGroupTypes.ts:32andTransactionDetailsFields/index.tsx:98.In
DescriptionField.tsx, on the inlineTextInput, passhint={descriptionHint}andshouldRenderHintAsHTML={!!descriptionHint}, mirroringDynamicIOURequestStepDescription.tsx:232-233, and render theRequiredaffordance from theisDescriptionRequiredprop so it stops being dead in that branch.Jest test: a category with a
commentHintrenders it, one without renders nothing, andisDescriptionRequiredrenders the marker.What alternative solutions did you explore? (Optional)
Reading
commentHintinsideDescriptionFieldfrom its own Onyx connection. Rejected: it duplicates a lookup the parent already performs and adds a subscription per field.Routing creation through
DynamicIOURequestStepDescriptionso the existing hint code runs. Rejected: that reintroduces the extra screen the new flow deliberately removes.Fixing only the hint and leaving
Requireddead. Worth a maintainer decision rather than my assumption, which is why I flagged it above; the two are the same three lines of JSX, so splitting them costs a second PR.76 remaining items
melvin-bot commentedon Oct 26, 2026
@Ollyws Huh... This is 4 days overdue. Who can take care of this?
lucasrocha20 commentedon Oct 26, 2026
I can get this, ok?
mallenexpensify commentedon Oct 27, 2026
@Ollyws plz provide an update with where we are here and what you're due. Thx
Ollyws commentedon Oct 27, 2026
The first PR was reverted due to two regressions. There were three linked issues:
#101512 - Regression
#101556 - Regression
#101519 - Already existed on prod (still existed after #101072 revert)
All three were fixed in a follow up PR.
Ollyws commentedon Oct 27, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: N/A, new feature.
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Precondition:
Do we agree 👍 or 👎
mallenexpensify commentedon Oct 27, 2026
Payment Summary
Contributor+: @Ollyws due $75 via NewDot
Went with $75 cuz OG price was $250 and there were two regressions. Comment/reopen if you disagree.
Thx for inc. this @Ollyws
flaviadefaria commentedon Nov 9, 2026
Approved: @Ollyws due $75 via NewDot